mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Manni Stefano <stefano.manni@eletechsrl.it>,
	barebox@lists.infradead.org,
	Aurelio Colosimo <aurelio@aureliocolosimo.it>
Subject: Re: imx6ul: fec: stuck on ifup after ifdown
Date: Tue, 6 Oct 2020 11:58:11 +0200	[thread overview]
Message-ID: <20201006095811.GF11648@pengutronix.de> (raw)
In-Reply-To: <8a0d7de81f77b7a2e4a689d7a1464a7617ad4ff2.camel@pengutronix.de>

On Tue, Oct 06, 2020 at 10:44:24AM +0200, Lucas Stach wrote:
> On Mo, 2020-10-05 at 17:17 +0200, Sascha Hauer wrote:
> > Hi Stefano,
> > 
> > On Mon, Oct 05, 2020 at 02:43:15PM +0200, Manni Stefano wrote:
> > > Hi,
> > > 
> > > on a custom board based on a i.MX6UL using barebox v2020.08.1 'ifup eth0'
> > > invoked after 'ifdown eth0' stucks forever.
> > > 
> > > Have you ever experienced something similar?
> > 
> > I can confirm the same happens here on an i.MX6q board on current
> > master. I don't know what's happening here. The last thing I see is that
> > fec_tx_task_enable() is entered. Strange enough the same works on i.MX53
> > whereas on i.MX8M I get "ERROR: eth0: transmission timeout" on the
> > second ifup.
> > 
> > This is really strange. It seems fec_tx_task_enable() brings down the
> > whole SoC, but on the other hand the FEC works properly in a chainloaded
> > barebox, which should - from the view of the ethernet controller - be
> > the same as a repeated ifup/ifdown sequence.
> 
> There is a crucial difference between the two things: in a chainloaded
> Barebox we go through the FEC driver probe again, before doing the next
> ifup. When going through probe a full reset of the FEC peripheral is
> done.

Actually I thought there is a full FEC reset in fec_halt():

	writel(readl(fec->regs + FEC_X_CNTRL) | FEC_ECNTRL_RESET,
		fec->regs + FEC_X_CNTRL);

I only saw the FEC_ECNTRL_RESET bit but didn't realize this goes to a
completely unrelated register. We should have a FEC_X_CNTRL_GTS define
for this.

Given that, the fec_halt/fec_init path really looks quite different from
the fec_probe/fec_init path.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-10-06  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 12:43 Manni Stefano
2020-10-05 15:17 ` Sascha Hauer
2020-10-06  8:44   ` Lucas Stach
2020-10-06  9:58     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006095811.GF11648@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=aurelio@aureliocolosimo.it \
    --cc=barebox@lists.infradead.org \
    --cc=l.stach@pengutronix.de \
    --cc=stefano.manni@eletechsrl.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox