From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! setenv: align with POSIX in handling of setenv(var, "")
Date: Mon, 16 Nov 2020 09:21:17 +0100 [thread overview]
Message-ID: <20201116082117.GY29830@pengutronix.de> (raw)
In-Reply-To: <20201113082600.30578-1-a.fatoum@pengutronix.de>
On Fri, Nov 13, 2020 at 09:26:00AM +0100, Ahmad Fatoum wrote:
> Previously setenv xxx= deleted x like xxx= does. With xxx= now instead
> assigning the empty string, setenv xxx= should too.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> ---
> commands/setenv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/commands/setenv.c b/commands/setenv.c
> index 6992f604f513..9aeb8f010bc5 100644
> --- a/commands/setenv.c
> +++ b/commands/setenv.c
> @@ -18,8 +18,7 @@ static int do_setenv(int argc, char *argv[])
> equal = strrchr(argv[1], '=');
> if (equal) {
> equal[0] = '\0';
> - if (equal[1])
> - argv[2] = &equal[1];
> + argv[2] = &equal[1];
> }
Fine with me, but I just had a second look at fbf145dc86 ("commands: setenv:
support setenv dev.var=VAL syntax"). This patch introduced using argv[2]
when argc was only to, thus only argv[0] and argv[1] are valid. I wonder
if this is allowed. KAsan doesn't complain, but still I think this
should be changed. Could you do this before further modifying this?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-11-16 8:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:23 [PATCH 1/2] fs: introduce unsetenv() to prepare for changing setenv(var, "") behavior Ahmad Fatoum
2020-11-12 17:23 ` [PATCH 2/2] setenv: align with POSIX in handling of setenv(var, "") Ahmad Fatoum
2020-11-13 8:26 ` [PATCH] fixup! " Ahmad Fatoum
2020-11-16 8:21 ` Sascha Hauer [this message]
2020-11-16 8:58 ` Ahmad Fatoum
2020-11-23 15:48 ` [PATCH 1/2] fs: introduce unsetenv() to prepare for changing setenv(var, "") behavior Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116082117.GY29830@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox