From: Jules Maselbas <jmaselbas@kalray.eu>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] usb: dwc2: cleanup on error for deferred probing
Date: Thu, 17 Dec 2020 12:00:37 +0100 [thread overview]
Message-ID: <20201217110030.54z7snifkf4slkpw@tellis.lin.mbt.kalray.eu> (raw)
In-Reply-To: <20201216204534.8054-2-m.grzeschik@pengutronix.de>
Hi Micheal,
I am testing your patches, but this one doesn't compile.
On Wed, Dec 16, 2020 at 09:45:30PM +0100, Michael Grzeschik wrote:
> The driver needs to cleanup the resources if an error occurred. Otherwise,
> on deferred probing, it will fail to take the resources for a second time.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> drivers/usb/dwc2/dwc2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/dwc2.c b/drivers/usb/dwc2/dwc2.c
> index bd33334a83..87d0ec7a5a 100644
> --- a/drivers/usb/dwc2/dwc2.c
> +++ b/drivers/usb/dwc2/dwc2.c
> @@ -53,7 +53,7 @@ static int dwc2_probe(struct device_d *dev)
> dwc2->phy = phy_optional_get(dev, "usb2-phy");
> if (IS_ERR(dwc2->phy)) {
> ret = PTR_ERR(dwc2->phy);
> - return ret;
> + goto release_region;
> }
>
> ret = phy_init(dwc2->phy);
> @@ -100,7 +100,8 @@ error:
> phy_power_off(dwc2->phy);
> err_phy_power:
> phy_exit(dwc2->phy);
> -err_phy_init:
> +release_region:
> + release_region(iores);
error: label ‘err_phy_init’ used but not defined
in drivers/usb/dwc2.c:61
ret = phy_init(dwc2->phy);
if (ret)
goto err_phy_init;
Jules
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-12-17 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 20:45 [PATCH 0/5] dwc2: improve gadget support Michael Grzeschik
2020-12-16 20:45 ` [PATCH 1/5] usb: dwc2: cleanup on error for deferred probing Michael Grzeschik
2020-12-17 11:00 ` Jules Maselbas [this message]
2020-12-16 20:45 ` [PATCH 2/5] usb: dwc2: add clk dependency for probe via oftree Michael Grzeschik
2020-12-16 20:45 ` [PATCH 3/5] usb: dwc2: add reset controller " Michael Grzeschik
2020-12-16 20:45 ` [PATCH 4/5] usb: dwc2: update the dr_mode on set_mode callback Michael Grzeschik
2020-12-16 20:45 ` [PATCH 5/5] usb: dwc2: add support to force gadget mode Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217110030.54z7snifkf4slkpw@tellis.lin.mbt.kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=barebox@lists.infradead.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox