From: Sascha Hauer <sha@pengutronix.de>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 2/5] usb: dwc2: add clk dependency for probe via oftree
Date: Wed, 6 Jan 2021 09:57:38 +0100 [thread overview]
Message-ID: <20210106085738.GK19063@pengutronix.de> (raw)
In-Reply-To: <20201217110731.14914-3-m.grzeschik@pengutronix.de>
On Thu, Dec 17, 2020 at 12:07:28PM +0100, Michael Grzeschik wrote:
> The dwc2 controller at least needs one core clock which needs to be
> enabled before it is able to address the core registers. This patch adds
> the referenced clock in the devicetree to be used.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> drivers/usb/dwc2/core.h | 1 +
> drivers/usb/dwc2/dwc2.c | 19 +++++++++++++++++--
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index b9845b5524..780efb262c 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -467,6 +467,7 @@ struct dwc2 {
> struct dwc2_core_params params;
>
> struct phy *phy; /* optional */
> + struct clk *clk;
>
> #ifdef CONFIG_USB_DWC2_HOST
> struct usb_host host;
> diff --git a/drivers/usb/dwc2/dwc2.c b/drivers/usb/dwc2/dwc2.c
> index 82b5ef2813..13455479ef 100644
> --- a/drivers/usb/dwc2/dwc2.c
> +++ b/drivers/usb/dwc2/dwc2.c
> @@ -50,15 +50,26 @@ static int dwc2_probe(struct device_d *dev)
> dwc2->regs = IOMEM(iores->start);
> dwc2->dev = dev;
>
> + dwc2->clk = clk_get(dev, NULL);
According to the binding doc the clock should be named "otg", I think
this should be changed accordingly.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-01-06 8:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 11:07 [PATCH v2 0/5] dwc2: improve gadget support Michael Grzeschik
2020-12-17 11:07 ` [PATCH v2 1/5] usb: dwc2: cleanup on error for deferred probing Michael Grzeschik
2020-12-17 11:07 ` [PATCH v2 2/5] usb: dwc2: add clk dependency for probe via oftree Michael Grzeschik
2021-01-06 8:57 ` Sascha Hauer [this message]
2021-01-06 9:42 ` [PATCH] fixup! " Michael Grzeschik
2020-12-17 11:07 ` [PATCH v2 3/5] usb: dwc2: add reset controller " Michael Grzeschik
2020-12-17 11:07 ` [PATCH v2 4/5] usb: dwc2: update the dr_mode on set_mode callback Michael Grzeschik
2020-12-17 11:07 ` [PATCH v2 5/5] usb: dwc2: add support to force gadget mode Michael Grzeschik
2020-12-17 11:39 ` [PATCH v2 0/5] dwc2: improve gadget support Jules Maselbas
2021-01-06 10:00 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106085738.GK19063@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox