From: Sascha Hauer <sha@pengutronix.de>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: imx: fix overcurrent polarity handling on i.MX7
Date: Thu, 4 Feb 2021 11:28:07 +0100 [thread overview]
Message-ID: <20210204102807.GA19583@pengutronix.de> (raw)
In-Reply-To: <20210202185413.18332-1-m.grzeschik@pengutronix.de>
On Tue, Feb 02, 2021 at 07:54:12PM +0100, Michael Grzeschik wrote:
> The reference manual says the overcurrent polarity is changed to low
> with the bit set. We fix that according to the description.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
> drivers/usb/imx/imx-usb-misc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/usb/imx/imx-usb-misc.c b/drivers/usb/imx/imx-usb-misc.c
> index b663d073aa..660ebecd78 100644
> --- a/drivers/usb/imx/imx-usb-misc.c
> +++ b/drivers/usb/imx/imx-usb-misc.c
> @@ -353,7 +353,7 @@ static __maybe_unused struct imx_usb_misc_data mx5_data = {
>
> #define MX6_USB_CTRL(n) ((n) * 4)
> #define MX6_USB_CTRL_OVER_CUR_DIS (1 << 7)
> -#define MX6_USB_CTRL_OVER_CUR_ACT_HIGH (1 << 8)
> +#define MX6_USB_CTRL_OVER_CUR_ACT_LOW (1 << 8)
> #define MX6_USB_CTRL_PWR_POLARITY (1 << 9)
>
> static void mx6_hsic_pullup(unsigned long reg, int on)
> @@ -453,9 +453,9 @@ static int usbmisc_imx7d_init(void __iomem *base, int port,
> } else {
> reg &= ~MX6_USB_CTRL_OVER_CUR_DIS;
> if (flags & MXC_EHCI_OC_PIN_ACTIVE_LOW)
> - reg &= ~MX6_USB_CTRL_OVER_CUR_ACT_HIGH;
> + reg |= MX6_USB_CTRL_OVER_CUR_ACT_LOW;
> else
> - reg |= MX6_USB_CTRL_OVER_CUR_ACT_HIGH;
> + reg &= ~MX6_USB_CTRL_OVER_CUR_ACT_LOW;
> }
> if (flags & MXC_EHCI_PWR_PIN_ACTIVE_HIGH)
> reg |= MX6_USB_CTRL_PWR_POLARITY;
> --
> 2.30.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-02-04 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 18:54 Michael Grzeschik
2021-02-02 18:54 ` [PATCH 2/2] usb: imx: add overcurrent polarity handling on i.MX6 Michael Grzeschik
2021-02-04 10:28 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204102807.GA19583@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox