From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH master] sandbox: fix unreliable block device detection
Date: Fri, 12 Feb 2021 10:00:07 +0100 [thread overview]
Message-ID: <20210212090007.GJ19583@pengutronix.de> (raw)
In-Reply-To: <20210212085148.19347-1-a.fatoum@pengutronix.de>
On Fri, Feb 12, 2021 at 09:51:48AM +0100, Ahmad Fatoum wrote:
> If barebox detects that an --image file is a block device, it will try
> to represent it as a block device internally as well, provided that
> the user didn't explicitly specify that it should be mapped as a
> character device instead. The hf_info::is_cdev member used to indicate
> this override wasn't initialized though, so detection was unreliable,
> Fix this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> arch/sandbox/os/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/sandbox/os/common.c b/arch/sandbox/os/common.c
> index da87be29c74d..56c2d0519388 100644
> --- a/arch/sandbox/os/common.c
> +++ b/arch/sandbox/os/common.c
> @@ -276,7 +276,7 @@ extern char * strsep_unescaped(char **s, const char *ct);
>
> static int add_image(const char *_str, char *devname_template, int *devname_number)
> {
> - struct hf_info *hf = malloc(sizeof(struct hf_info));
> + struct hf_info *hf = calloc(1, sizeof(struct hf_info));
> char *str, *filename, *devname;
> char tmp[16];
> char *opt;
> --
> 2.29.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-02-12 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 8:51 Ahmad Fatoum
2021-02-12 9:00 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212090007.GJ19583@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox