From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 3/3] common: shell: select dependency GLOB for SHELL_SIMPLE
Date: Fri, 19 Mar 2021 19:26:08 +0100 [thread overview]
Message-ID: <20210319182608.5054-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20210319182608.5054-1-a.fatoum@pengutronix.de>
Both CONFIG_SHELL_HUSH and CONFIG_SHELL_SIMPLE will call run_init, which
already uses glob to collect the init scripts to run. select GLOB to
make sure that these scripts are executed. If there is a use case for
a shell configuration without glob support to save on size, this should
be realized by a new Kconfig symbol to disable the init scripts.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/Kconfig b/common/Kconfig
index 8abd47a7569a..342817bbcbb4 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -413,6 +413,7 @@ choice
select PARAMETER
select BINFMT
select STDDEV
+ select GLOB
help
Enable hush support. This is the most advanced shell available
for barebox.
@@ -424,6 +425,7 @@ choice
select PARAMETER
select STDDEV
select CMD_SETENV
+ select GLOB
help
simple shell. No if/then, no return values from commands, no loops
--
2.29.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-03-19 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 18:26 [PATCH master 1/3] glob: use empty globfree when compiling without CONFIG_GLOB Ahmad Fatoum
2021-03-19 18:26 ` [PATCH master 2/3] common: boot: select dependency CONFIG_GLOB Ahmad Fatoum
2021-03-19 18:26 ` Ahmad Fatoum [this message]
2021-03-22 4:47 ` [PATCH master 1/3] glob: use empty globfree when compiling without CONFIG_GLOB Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319182608.5054-3-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox