From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: i.MX: Add missing braces
Date: Tue, 13 Apr 2021 12:08:27 +0200 [thread overview]
Message-ID: <20210413100827.GN19819@pengutronix.de> (raw)
In-Reply-To: <6835e212-133c-e2f8-6e05-336e6877543c@pengutronix.de>
On Tue, Apr 13, 2021 at 11:56:10AM +0200, Ahmad Fatoum wrote:
> Hi,
>
> On 13.04.21 11:03, Sascha Hauer wrote:
> > Add braces around the definition of imx1_gpio_val and imx31_gpio_val
> > to make sure it's evaluated correctly.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/mach-imx/include/mach/imx-gpio.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/include/mach/imx-gpio.h b/arch/arm/mach-imx/include/mach/imx-gpio.h
> > index 0cfd16f4fa..b9a6acc013 100644
> > --- a/arch/arm/mach-imx/include/mach/imx-gpio.h
> > +++ b/arch/arm/mach-imx/include/mach/imx-gpio.h
> > @@ -72,11 +72,11 @@ static inline void imx31_gpio_direction_input(void *base, int gpio)
> > #define imx6_gpio_direction_input(base, gpio) imx31_gpio_direction_input(base, gpio)
> > #define imx8m_gpio_direction_input(base, gpio) imx31_gpio_direction_input(base, gpio)
> >
> > -#define imx1_gpio_val(base, gpio) readl(base + 0x1c) & (1 << gpio) ? 1 : 0
> > +#define imx1_gpio_val(base, gpio) (readl(base + 0x1c) & (1 << gpio) ? 1 : 0)
>
> Braces around base and especially gpio might be a good idea as well.
> You never know..
Right. I converted the macros to static inline functions instead.
Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-04-13 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 9:03 Sascha Hauer
2021-04-13 9:56 ` Ahmad Fatoum
2021-04-13 10:08 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413100827.GN19819@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox