mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <>
Cc: Ahmad Fatoum <>
Subject: [PATCH 1/2] fixup! gpio: generic: sync with upstream Linux gpio-mmio driver
Date: Tue, 11 May 2021 08:41:43 +0200	[thread overview]
Message-ID: <> (raw)

Commit inadvertently broke brcm,bcm6345-gpio, wd,mbl-gpio and
ni,169445-nand-gpio, because "dat" was now requested twice.

Fix this up. Tested on RISC-V Erizo.

Reported-by: Antony Pavlov <>
Signed-off-by: Ahmad Fatoum <>
 drivers/gpio/gpio-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index 713085267a15..3066b3f7a19d 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -537,7 +537,7 @@ static int bgpio_dev_probe(struct device_d *dev)
 	if (IS_ERR(pdata))
 		return PTR_ERR(pdata);
-	r = dev_request_mem_resource_by_name(dev, "dat");
+	r = dev_get_resource_by_name(dev, IORESOURCE_MEM, "dat");
 	if (!r)
 		return -EINVAL;

barebox mailing list

             reply	other threads:[~2021-05-11 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  6:41 Ahmad Fatoum [this message]
2021-05-11  6:41 ` [PATCH 2/2] RISC-V: extend multi-image to support both S- and M-Mode Ahmad Fatoum
2021-05-11 11:11   ` Antony Pavlov
2021-05-11 11:26     ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox