mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org,
	Marco Felsch <m.felsch@pengutronix.de>,
	Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2] usb: i.MX: warn if vbus regulator isn't available
Date: Tue, 25 May 2021 07:24:59 +0200	[thread overview]
Message-ID: <20210525052459.GH31738@pengutronix.de> (raw)
In-Reply-To: <20210305090001.3619780-1-u.kleine-koenig@pengutronix.de>

On Fri, Mar 05, 2021 at 10:00:01AM +0100, Uwe Kleine-König wrote:
> Instead of just ignoring errors related to getting the vbus regulator
> yield at least a warning message. This would have saved me some
> debugging time when trying to understand why USB doesn't work without
> the right regulator driver enabled.
> 
> Note that machines that don't define a regulator in their device tree
> don't issue this warning as regulator_get() returns the dummy regulator
> in this case.

Note that this warning appears on machines that do define a regulator in
their device tree (derived from the kernel upstream dts), but do not
actually need it as the regulator was enabled by board code.
Arguably that's the problem of these boards and we'll have to look there
how we can quiesce the warning. The obvious solution is to implement the
missing driver, but we could also add some
add_dummy_regulator_for_this_node() function to tell the regulator core
that we don't need a specific regulator.

First let's see if somebody is annoyed by this message, so applied,
thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-05-25  5:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  9:00 Uwe Kleine-König
2021-05-22 14:22 ` Uwe Kleine-König
2021-05-25  5:24 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525052459.GH31738@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --subject='Re: [PATCH v2] usb: i.MX: warn if vbus regulator isn'\''t available' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox