mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Holger Assmann <h.assmann@pengutronix.de>,
	barebox@lists.infradead.org,
	Rouven Czerwinski <r.czerwinski@pengutronix.de>
Subject: Re: [PATCH v3] ARM: webasto-ccbv2: Add variant with 512MB RAM
Date: Tue, 25 May 2021 07:46:15 +0200	[thread overview]
Message-ID: <20210525054615.GI31738@pengutronix.de> (raw)
In-Reply-To: <9fd00674-7953-f510-f2e5-fe076ef00b9b@pengutronix.de>

On Tue, May 18, 2021 at 01:33:43PM +0200, Ahmad Fatoum wrote:
> 
> On 18.05.21 12:57, Holger Assmann wrote:
> > -$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2, imx6ul-webasto-ccbv2)
> > +$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2-256, imx6ul-webasto-ccbv2-256m)
> > +
> > +$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2-512, imx6ul-webasto-ccbv2-512m)
> 
> I think this is the first board that uses the exact same entry point, but different
> *.imxcfg. I built the patch to see if this actually does what it should and it
> doesn't seem to be the case: both images/barebox-imx6ul-webasto-ccbv2-256m.img
> and images/barebox-imx6ul-webasto-ccbv2-512m.img are identical..

This happens because we intermediately create the file
images/start_imx6ul_ccbv2.pblb.imximg. We would have to create two
different imx images, one for each config file. This doesn't fit into
the build process currently, so let's go with v4 holger has sent.

We could add IMD tags for the memsize like Phytec has done:

BAREBOX_IMD_TAG_STRING(physom_mx6_memsize_SZ_256M, IMD_TYPE_PARAMETER, "memsize=256", 0);

That would at least otherwise justify that we need different entry
points ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-25  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 10:57 Holger Assmann
2021-05-18 11:20 ` Ahmad Fatoum
2021-05-18 11:33 ` Ahmad Fatoum
2021-05-25  5:46   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210525054615.GI31738@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=h.assmann@pengutronix.de \
    --cc=r.czerwinski@pengutronix.de \
    --subject='Re: [PATCH v3] ARM: webasto-ccbv2: Add variant with 512MB RAM' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox