mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v3] ARM: i.MX: sabresd: Add support for i.MX6QP board variant
Date: Wed, 26 May 2021 09:24:58 +0200	[thread overview]
Message-ID: <20210526072458.GR31738@pengutronix.de> (raw)
In-Reply-To: <395d50ec-c2b6-94f8-ceff-bf76d3ec497b@pengutronix.de>

On Wed, May 26, 2021 at 09:22:41AM +0200, Ahmad Fatoum wrote:
> 
> 
> On 26.05.21 08:42, Sascha Hauer wrote:
> > The SabreSD comes with different SoC variants. This patch adds support
> > for the i.MX6QP based board. the DCD data has been taken from U-Boot
> > 2021.04
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Link: https://lore.barebox.org/20210415140313.29161-1-s.hauer@pengutronix.de
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > 
> > Changes since v2:
> > - Fix board compatible checks to also match "fsl,imx6qp-sabresd"
> > 
> >  arch/arm/boards/freescale-mx6-sabresd/board.c |  6 +-
> >  ...mxcfg => flash-header-mx6q-sabresd.imxcfg} |  0
> >  .../flash-header-mx6qp-sabresd.imxcfg         | 96 +++++++++++++++++++
> >  .../boards/freescale-mx6-sabresd/lowlevel.c   | 16 ++++
> >  arch/arm/dts/Makefile                         |  2 +-
> >  arch/arm/dts/imx6qp-sabresd.dts               | 42 ++++++++
> >  images/Makefile.imx                           |  4 +-
> >  7 files changed, 162 insertions(+), 4 deletions(-)
> >  rename arch/arm/boards/freescale-mx6-sabresd/{flash-header-mx6-sabresd.imxcfg => flash-header-mx6q-sabresd.imxcfg} (100%)
> >  create mode 100644 arch/arm/boards/freescale-mx6-sabresd/flash-header-mx6qp-sabresd.imxcfg
> >  create mode 100644 arch/arm/dts/imx6qp-sabresd.dts
> > 
> > diff --git a/arch/arm/boards/freescale-mx6-sabresd/board.c b/arch/arm/boards/freescale-mx6-sabresd/board.c
> > index b710c05a47..4df6663775 100644
> > --- a/arch/arm/boards/freescale-mx6-sabresd/board.c
> > +++ b/arch/arm/boards/freescale-mx6-sabresd/board.c
> > @@ -55,7 +55,8 @@ static int ar8031_phy_fixup(struct phy_device *dev)
> >  
> >  static int sabresd_devices_init(void)
> >  {
> > -	if (!of_machine_is_compatible("fsl,imx6q-sabresd"))
> > +	if (!of_machine_is_compatible("fsl,imx6q-sabresd") &&
> > +	    !of_machine_is_compatible("fsl,imx6q-sabresd"))
> 
> That's the same compatible string twice.

Yeah, just realized that as well when I tried to close the editor window and was
asked to save or discard the changes :). Fixed.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-26  7:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  6:42 Sascha Hauer
2021-05-26  7:22 ` Ahmad Fatoum
2021-05-26  7:24   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526072458.GR31738@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox