mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs: nfs: Decrease NFS timeout
Date: Thu, 27 May 2021 09:20:36 +0200
Message-ID: <20210527072036.GE19819@pengutronix.de> (raw)
In-Reply-To: <20210526094448.977342-1-u.kleine-koenig@pengutronix.de>

Hi Uwe,

On Wed, May 26, 2021 at 11:44:48AM +0200, Uwe Kleine-König wrote:
> On a customer site we're experience a bit over 1% UDP packet loss. When
> wiresharking an NFS transfer of a kernel image (with the goal to boot
> via NFS) I saw 64 of 2555 RPC calls staying unanswered. With the current
> timeout setting each of them introduces a delay of 2 seconds and the
> whole transfer takes 137s. With the timeout reduced to 0.1s the transfer
> time is not optimal (going down to approx 15 seconds) but at least it
> becomes bearable.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  fs/nfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs.c b/fs/nfs.c
> index 1130632eb3eb..1ff81a5ee1bf 100644
> --- a/fs/nfs.c
> +++ b/fs/nfs.c
> @@ -119,7 +119,7 @@ struct rpc_reply {
>  	uint32_t data[0];
>  };
>  
> -#define NFS_TIMEOUT	(2 * SECOND)
> +#define NFS_TIMEOUT	(100 * MSECOND)
>  #define NFS_MAX_RESEND	5

Should we increase NFS_MAX_RESEND at the same time? Otherwise we timeout
after 500ms which doesn't seem much to me on some network hickups.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-05-27  7:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:44 Uwe Kleine-König
2021-05-27  7:20 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210527072036.GE19819@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git