From: Sascha Hauer <sha@pengutronix.de> To: Ahmad Fatoum <ahmad@a3f.at> Cc: barebox@lists.infradead.org Subject: Re: [PATCH] driver: have dev_set_name() return 0 on success Date: Mon, 31 May 2021 09:22:03 +0200 Message-ID: <20210531072203.GG5211@pengutronix.de> (raw) In-Reply-To: <20210529082953.2034104-1-ahmad@a3f.at> On Sat, May 29, 2021 at 10:29:53AM +0200, Ahmad Fatoum wrote: > Align the return code with Linux, where the function returns 0, not the > device name length on success. No functional change, as no one checks > the error code anyway. > > Signed-off-by: Ahmad Fatoum <ahmad@a3f.at> > --- > drivers/base/driver.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/base/driver.c b/drivers/base/driver.c > index f60533c59eb1..1fa3f6c6fac0 100644 > --- a/drivers/base/driver.c > +++ b/drivers/base/driver.c > @@ -480,9 +480,7 @@ int dev_set_name(struct device_d *dev, const char *fmt, ...) > */ > free(oldname); > > - WARN_ON(err < 0); > - > - return err; > + return WARN_ON(err < 0) ? err : 0; > } > EXPORT_SYMBOL_GPL(dev_set_name); > > -- > 2.31.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-05-31 7:23 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-29 8:29 Ahmad Fatoum 2021-05-31 7:22 ` Sascha Hauer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210531072203.GG5211@pengutronix.de \ --to=sha@pengutronix.de \ --cc=ahmad@a3f.at \ --cc=barebox@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
mail archive of the barebox mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \ barebox@lists.infradead.org barebox@lists.infradead.org public-inbox-index barebox Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git