mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] bthread: remove thread exit codes
Date: Mon, 28 Jun 2021 14:45:16 +0200	[thread overview]
Message-ID: <20210628124516.GK9782@pengutronix.de> (raw)
In-Reply-To: <20210628070732.16812-1-a.fatoum@pengutronix.de>

On Mon, Jun 28, 2021 at 09:07:30AM +0200, Ahmad Fatoum wrote:
> Follow-up commit will replace blocking bthread_stop with non-blocking
> bthread_cancel. Prepare for this by dropping exit codes. This is not
> much of a loss, because most users of bthreads will only call
> bthread_stop at cleanup time. bthread command is an exception, so have
> it take manual care of passing around exit codes.
> 
> As we touch the bthread_stop prototype anyway, rename it to
> __bthread_stop. This will make it clearer in the future, that it's not
> meant for driver use.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  commands/bthread.c                  | 48 ++++++++++++++++++-----------
>  common/bthread.c                    | 20 ++++++------
>  drivers/usb/gadget/f_mass_storage.c | 12 +++-----
>  include/bthread.h                   |  5 +--
>  4 files changed, 47 insertions(+), 38 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-06-28 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  7:07 Ahmad Fatoum
2021-06-28  7:07 ` [PATCH 2/3] bthread: replace blocking bthread_stop with nonblocking bthread_cancel Ahmad Fatoum
2021-06-28  7:07 ` [PATCH 3/3] bthread: add options to create and delete dummy bthreads Ahmad Fatoum
2021-06-28 12:45 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628124516.GK9782@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --subject='Re: [PATCH 1/3] bthread: remove thread exit codes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox