mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! sandbox: ship sample environment
Date: Mon, 28 Jun 2021 22:16:02 +0200	[thread overview]
Message-ID: <20210628201602.GP9782@pengutronix.de> (raw)
In-Reply-To: <20210628063928.1083081-1-ahmad@a3f.at>

On Mon, Jun 28, 2021 at 08:39:28AM +0200, Ahmad Fatoum wrote:
> The sample environment contained a new line as its 4K+1th byte, when it
> should have been only 4K big. Drop the new line. No functional change.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  --- old
>  +++ new
>  @@ -254,4 +254,3 @@
>   00000fd0: 0000 0000 0000 0000 0000 0000 0000 0000  ................
>   00000fe0: 0000 0000 0000 0000 0000 0000 0000 0000  ................
>   00000ff0: 0000 0000 0000 0000 0000 0000 0000 0000  ................
>  -00001000: 0a                                       .
> ---
>  arch/sandbox/board/stickypage.bin | Bin 4097 -> 4096 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)

In accordance with Ahmad I dropped this one and the patch introducing
stickypage.bin. Handling binary files in git is fine, but unfortunately
it doesn't work with a patch workflow when it comes to integrating them
as a patch in a BSP.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-06-28 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  6:39 Ahmad Fatoum
2021-06-28 20:16 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628201602.GP9782@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox