From: Sascha Hauer <sha@pengutronix.de>
To: Jules Maselbas <jmaselbas@kalray.eu>
Cc: barebox@lists.infradead.org,
"Anže Lešnik" <anze.lesnik@norik.com>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2] usb: gadget: dfu: Rework dfu command to use usbgadget
Date: Mon, 4 Oct 2021 13:45:56 +0200 [thread overview]
Message-ID: <20211004114556.GB28453@pengutronix.de> (raw)
In-Reply-To: <20210910102931.26078-1-jmaselbas@kalray.eu>
On Fri, Sep 10, 2021 at 12:29:31PM +0200, Jules Maselbas wrote:
> The dfu command now uses the composite multi gadget to register the usb
> functionality. This allows the removal of the usb composite driver from
> dfu.c
>
> As the dfu command is blocking the command slice must be released while
> the dfu gadget is running in order to do operations on the file system.
>
> The usb_dfu_register() function is replaced with usb_dfu_detached() for
> the dfu command to return a different value depending on if it has been
> interrupted with CTRL-C or if the gadget has been detached.
>
> Tested-by: Anže Lešnik <anze.lesnik@norik.com>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
>
> ---
> changes in v2:
> - Rebased on next: update for the new usbgadget_register() prototype
> ---
> commands/dfu.c | 29 +++----
> drivers/usb/gadget/dfu.c | 163 +--------------------------------------
> include/usb/dfu.h | 2 +-
> 3 files changed, 18 insertions(+), 176 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-10-04 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 10:29 Jules Maselbas
2021-10-04 11:45 ` Sascha Hauer [this message]
2021-10-04 12:11 ` Jules Maselbas
2021-10-14 7:30 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004114556.GB28453@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=anze.lesnik@norik.com \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox