mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] state: backend_raw: fix ignoring unpack failures
Date: Mon, 4 Oct 2021 13:50:13 +0200	[thread overview]
Message-ID: <20211004115013.GC28453@pengutronix.de> (raw)
In-Reply-To: <20210825144904.4929-1-m.felsch@pengutronix.de>

On Wed, Aug 25, 2021 at 04:49:04PM +0200, Marco Felsch wrote:
> This is required to inform the state framework that the state variable
> set have changed and we need to write the new variable set. Without this
> fix the new variable set is never written since the state never sets
> dirty=1 and so state_save() will return early without saving the new
> variable set.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> I keeped the continue instead of break out early so the user gets
> informed which variables do not fit.
> 
> Regards,
>   Marco
> 
>  common/state/backend_format_raw.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      reply	other threads:[~2021-10-04 11:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 14:49 Marco Felsch
2021-10-04 11:50 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004115013.GC28453@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox