From: Sascha Hauer <s.hauer@pengutronix.de> To: Barebox List <barebox@lists.infradead.org> Subject: [PATCH 6/9] usb: dwc3: Clarify error message Date: Mon, 11 Oct 2021 10:03:43 +0200 [thread overview] Message-ID: <20211011080346.37197-7-s.hauer@pengutronix.de> (raw) In-Reply-To: <20211011080346.37197-1-s.hauer@pengutronix.de> When the DWC3 controller uses a mode which is currently not compiled into barebox we answer with "Controller does not support ... mode". Make clear that it's not the controller which doesn't support it, but the currently running barebox. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/usb/dwc3/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index f618435cb6..17caf136ef 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -43,7 +43,7 @@ static int dwc3_get_dr_mode(struct dwc3 *dwc) case DWC3_GHWPARAMS0_MODE_GADGET: if (IS_ENABLED(CONFIG_USB_DWC3_HOST)) { dev_err(dev, - "Controller does not support host mode.\n"); + "This barebox does not support DWC3 host mode.\n"); return -EINVAL; } mode = USB_DR_MODE_PERIPHERAL; @@ -51,7 +51,7 @@ static int dwc3_get_dr_mode(struct dwc3 *dwc) case DWC3_GHWPARAMS0_MODE_HOST: if (IS_ENABLED(CONFIG_USB_DWC3_GADGET)) { dev_err(dev, - "Controller does not support device mode.\n"); + "This barebox does not support DWC3 device mode.\n"); return -EINVAL; } mode = USB_DR_MODE_HOST; -- 2.30.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-10-11 8:05 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-11 8:03 [PATCH 0/9] RK3568 updates Sascha Hauer 2021-10-11 8:03 ` [PATCH 1/9] phy: rockchip: Add dummy driver for child node Sascha Hauer 2021-10-11 8:03 ` [PATCH 2/9] ARM: Rockchip rk3568 EVB: Enable deep probe Sascha Hauer 2021-10-11 8:03 ` [PATCH 3/9] ARM: Rockchip: rk3568 EVB: use 64bit partition sizes Sascha Hauer 2021-10-11 8:03 ` [PATCH 4/9] phy: rockchip-inno-usb2: handle disabled child nodes gracefully Sascha Hauer 2021-10-11 8:03 ` [PATCH 5/9] usb: dwc3: reset controller before using it Sascha Hauer 2021-10-11 8:03 ` Sascha Hauer [this message] 2021-10-11 17:43 ` [PATCH 6/9] usb: dwc3: Clarify error message Trent Piepho 2021-10-12 7:10 ` Sascha Hauer 2021-10-11 8:03 ` [PATCH 7/9] ARM: rk3568: Detect USB boot Sascha Hauer 2021-10-11 17:53 ` Trent Piepho 2021-10-12 7:15 ` Sascha Hauer 2021-10-11 8:03 ` [PATCH 8/9] cdev: Add function to get unallocated start of device Sascha Hauer 2021-10-11 8:03 ` [PATCH 9/9] ARM: Rockchip: RK3568: implement failsafe barebox update Sascha Hauer 2021-10-11 9:59 ` Michael Riesch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211011080346.37197-7-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH 6/9] usb: dwc3: Clarify error message' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox