From: Sascha Hauer <sha@pengutronix.de> To: Trent Piepho <trent.piepho@igorinstitute.com> Cc: Barebox List <barebox@lists.infradead.org> Subject: Re: [PATCH] nandtest: Add more fields when bad byte found Date: Tue, 12 Oct 2021 09:46:21 +0200 [thread overview] Message-ID: <20211012074621.GK28453@pengutronix.de> (raw) In-Reply-To: <20211011190725.856597-1-trent.piepho@igorinstitute.com> On Mon, Oct 11, 2021 at 12:07:25PM -0700, Trent Piepho wrote: > This can help to determine what is causing the problem. E.g., is the > bad byte always in the same eraseblock? Is it always 513 bytes into a > page with a hardware ECC chunk size of 512 bytes? > > Example before and after (error at absolute address 123456 with 128kB > eraseblock and 2kB page sizes): > > Byte 0xe240 is 12 should be 34 > Block 0x1 byte 0xe240 (page 0x1c offset 0x240) is 0x12 should be 0x34 > > Signed-off-by: Trent Piepho <trent.piepho@igorinstitute.com> > --- > commands/nandtest.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied, thanks Sascha > > diff --git a/commands/nandtest.c b/commands/nandtest.c > index 1bb59c7fd..4a7db9cc7 100644 > --- a/commands/nandtest.c > +++ b/commands/nandtest.c > @@ -169,8 +169,10 @@ static int erase_and_write(loff_t ofs, unsigned char *data, > printf("\ncompare failed. seed %d\n", seed); > for (i = 0; i < meminfo.erasesize; i++) { > if (data[i] != rbuf[i]) > - printf("Byte 0x%x is %02x should be %02x\n", > - i, rbuf[i], data[i]); > + printf("Block 0x%llx byte 0x%0x (page 0x%x offset 0x%x) is %02x should be %02x\n", > + div64_ul(ofs, meminfo.erasesize), i, > + i / meminfo.writesize, i % meminfo.writesize, > + rbuf[i], data[i]); > } > return ret; > } > -- > 2.31.1 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-10-12 7:47 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-11 19:07 Trent Piepho 2021-10-12 7:46 ` Sascha Hauer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211012074621.GK28453@pengutronix.de \ --to=sha@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=trent.piepho@igorinstitute.com \ --subject='Re: [PATCH] nandtest: Add more fields when bad byte found' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox