From: "Daniel Brát" <danek.brat@gmail.com>
To: jmaselbas@kalray.eu
Cc: barebox@lists.infradead.org, danek.brat@gmail.com, sha@pengutronix.de
Subject: Re: [PATCH 1/2 v2] usb: dwc2: Make having a phy optional
Date: Wed, 20 Oct 2021 11:07:38 +0200 [thread overview]
Message-ID: <20211020090738.4399-1-danek.brat@gmail.com> (raw)
In-Reply-To: <20211019161654.GA26849@tellis.lin.mbt.kalray.eu>
Hi Jules,
On Tue, 19 Oct 2021 18:16:54 +0200, Jules Maselbas wrote:
> I am interested in getting this modification merged. Beside I don't
> think the dwc2 driver modification is needed, as phy_optional_get is
> intended to return NULL when no phy are available. For me it makes
> sense that NULL could be return by phy_optional_get when the phy
> support is not compiled in.
>
> Do you have the time to send a new patch with only this modification ?
I apologize for not responding to this thread sooner, had a lot on my plate
lately. I agree that simply having the 'phy_optional_get' return NULL when
unimplemented is better than making changes in the dwc2 driver itself and
it makes sense in general for it to behave this ways. All the other functions
using the phy already check for NULL anyway, so it is perfect fit.
I submitted it as a new patch as you suggested.
Daniel
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-10-20 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 7:46 [PATCH 0/2] usb: dwc2: fix phy dependecy Daniel Brát
2021-09-08 7:46 ` [PATCH 1/2] usb: dwc2: Make having a phy optional Daniel Brát
2021-09-08 8:50 ` Jules Maselbas
2021-09-08 12:58 ` [PATCH 1/2 v2] " Daniel Brát
2021-10-04 10:06 ` Sascha Hauer
2021-10-19 16:16 ` Jules Maselbas
2021-10-20 9:07 ` Daniel Brát [this message]
2021-10-20 9:48 ` Jules Maselbas
2021-09-08 7:46 ` [PATCH 2/2] ARM: rpi_defconfig: Enable PHY core for dwc2 usb driver Daniel Brát
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020090738.4399-1-danek.brat@gmail.com \
--to=danek.brat@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=jmaselbas@kalray.eu \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox