mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] misc: acpi-test: bump down debug message on remove
Date: Mon, 1 Nov 2021 11:28:52 +0100	[thread overview]
Message-ID: <20211101102852.GT25698@pengutronix.de> (raw)
In-Reply-To: <20211030175446.2274194-1-a.fatoum@pengutronix.de>

On Sat, Oct 30, 2021 at 07:54:43PM +0200, Ahmad Fatoum wrote:
> The ACPI test driver is meant to serve as template for adding more
> useful drivers. Printing a message in remove isn't a pattern that should
> be copied, so bump the level down.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/misc/acpi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/misc/acpi-test.c b/drivers/misc/acpi-test.c
> index 1d6814ebcf27..784c80cc5b8b 100644
> --- a/drivers/misc/acpi-test.c
> +++ b/drivers/misc/acpi-test.c
> @@ -47,7 +47,7 @@ static int acpi_test_probe(struct device_d *dev)
>  
>  static void acpi_test_remove(struct device_d *dev)
>  {
> -	dev_info(dev, "FADT driver removed\n");
> +	dev_dbg(dev, "FADT driver removed\n");
>  }
>  
>  static struct acpi_driver acpi_test_driver = {
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


      parent reply	other threads:[~2021-11-01 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30 17:54 Ahmad Fatoum
2021-10-30 17:54 ` [PATCH 2/4] usb: dwc3: remove unneeded EPROBE_DEFER check Ahmad Fatoum
2021-10-30 17:54 ` [PATCH 3/4] serial: atmel: abort probe on atmel_serial_init_port failure Ahmad Fatoum
2021-10-30 17:54 ` [PATCH 4/4] spi: zynq_qspi: don't check clk_get return value for NULLness Ahmad Fatoum
2021-11-01 10:28 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211101102852.GT25698@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox