mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ian Abbott <>
Cc: Steffen Trumtrar <>,
	Ian Abbott <>
Subject: [PATCH 1/2] ARM: Terasic DE0-Nano-SoC/Atlas-SoC: Use upstream compatible string
Date: Fri,  5 Nov 2021 12:21:45 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

The upstream (Linux) 'compatible' string for the Terasic
DE0-Nano-SoC/Atlas-SoC board in
"dts/src/arm/socfpga_cyclone5_de0_nano_soc.dts" differs from the barebox
'compatible' string for the same board in

Linux: "terasic,de0-atlas"
barebox:  "terasic,de0-nano-soc"

That results in an incompatibility when trying to boot a bootloader spec
entry with a 'devicetree' key that refers to the DTB file built from the
Linux sources.  The barebox bootloader spec loader will ignore the entry
because the 'compatible' string in the root node of the DTB does not
match what barebox expects.

Remove the 'compatible' string list from
"arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts" so that barebox uses
the upstream compatible string list.  Also remove the 'model' string
("Terasic DE0-Nano-SoC/Atlas-SoC Kit") so that barebox uses the upstream
(and shorter!) model name ("Terasic DE-0(Atlas)").

Finally, update the `of_machine_is_compatible("terasic,de0-nano-soc")`
function call in `socfpga_init()` to use the "terasic,de0-atlas" string.

Cc: Steffen Trumtrar <>
Signed-off-by: Ian Abbott <>
 arch/arm/boards/terasic-de0-nano-soc/board.c   | 2 +-
 arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/boards/terasic-de0-nano-soc/board.c b/arch/arm/boards/terasic-de0-nano-soc/board.c
index 8e69319d17..c6036a41f9 100644
--- a/arch/arm/boards/terasic-de0-nano-soc/board.c
+++ b/arch/arm/boards/terasic-de0-nano-soc/board.c
@@ -24,7 +24,7 @@ static int phy_fixup(struct phy_device *dev)
 static int socfpga_init(void)
-	if (!of_machine_is_compatible("terasic,de0-nano-soc"))
+	if (!of_machine_is_compatible("terasic,de0-atlas"))
 		return 0;
diff --git a/arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts b/arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts
index 427f150fb4..c737b091a7 100644
--- a/arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts
+++ b/arch/arm/dts/socfpga_cyclone5_de0_nano_soc.dts
@@ -19,9 +19,6 @@
 #include "socfpga.dtsi"
 / {
-	model = "Terasic DE0-Nano-SoC/Atlas-SoC Kit";
-	compatible = "terasic,de0-nano-soc","altr,socfpga-cyclone5", "altr,socfpga";
 	chosen {
 		stdout-path = &uart0;

barebox mailing list

  reply	other threads:[~2021-11-05 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-05 12:21 [PATCH 0/2] ARM: socfpga: Use upstream compatible strings Ian Abbott
2021-11-05 12:21 ` Ian Abbott [this message]
2021-11-05 12:21 ` [PATCH 2/2] ARM: Terasic SoCkit: Use upstream compatible string Ian Abbott
2021-11-08  8:11 ` [PATCH 0/2] ARM: socfpga: Use upstream compatible strings Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox