From: Jules Maselbas <jmaselbas@kalray.eu>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] debug_ll: ns16550: Fix interrupt disable on init
Date: Thu, 18 Nov 2021 13:33:57 +0100 [thread overview]
Message-ID: <20211118123357.GF1022@tellis.lin.mbt.kalray.eu> (raw)
In-Reply-To: <20211004073842.14809-1-jmaselbas@kalray.eu>
ping
On Mon, Oct 04, 2021 at 09:38:42AM +0200, Jules Maselbas wrote:
> The debug_ll_write_reg function takes first the register
> and secondly the value to write, which in this call were
> inverted. Fix the argument order.
>
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
> include/debug_ll/ns16550.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/debug_ll/ns16550.h b/include/debug_ll/ns16550.h
> index 7e4dbeb453..373c917d86 100644
> --- a/include/debug_ll/ns16550.h
> +++ b/include/debug_ll/ns16550.h
> @@ -43,7 +43,7 @@ static inline uint16_t debug_ll_ns16550_calc_divisor(unsigned long clk)
> static inline void debug_ll_ns16550_init(uint16_t divisor)
> {
> debug_ll_write_reg(NS16550_LCR, 0x0); /* select ier reg */
> - debug_ll_write_reg(0x00, NS16550_IER);
> + debug_ll_write_reg(NS16550_IER, 0x0); /* disable interrupts */
>
> debug_ll_write_reg(NS16550_LCR, NS16550_LCR_BKSE);
> debug_ll_write_reg(NS16550_DLL, divisor & 0xff);
> --
> 2.17.1
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-11-18 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 7:38 Jules Maselbas
2021-11-18 12:33 ` Jules Maselbas [this message]
2021-11-22 9:10 ` Sascha Hauer
2021-11-22 9:09 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118123357.GF1022@tellis.lin.mbt.kalray.eu \
--to=jmaselbas@kalray.eu \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox