From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: barebox@lists.infradead.org Subject: [PATCH] mci: bcm2835: Don't send MMC_CMD_GO_IDLE_STATE at the end of .init() Date: Tue, 30 Nov 2021 21:30:26 +0100 [thread overview] Message-ID: <20211130203026.360693-1-u.kleine-koenig@pengutronix.de> (raw) The core sends this command anyhow shortly after calling .init(). So doing it in bcm2835_mci_reset() is only overhead if it succeeds and if there is a problem it is noticed a tad earlier which has little benefit compared to the timeout in bcm2835_mci_wait_command_done(). So simplify and drop the transfer. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/mci/mci-bcm2835.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c index 4913dc27f8a3..10f588930cda 100644 --- a/drivers/mci/mci-bcm2835.c +++ b/drivers/mci/mci-bcm2835.c @@ -352,10 +352,7 @@ static int bcm2835_mci_reset(struct mci_host *mci, struct device_d *mci_dev) sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, 0xFFFFFFFF); - /*Now write command 0 and see if we get response*/ - sdhci_write32(&host->sdhci, SDHCI_ARGUMENT, 0x0); - sdhci_write32(&host->sdhci, SDHCI_TRANSFER_MODE__COMMAND, 0x0); - return bcm2835_mci_wait_command_done(host); + return 0; } static int bcm2835_mci_probe(struct device_d *hw_dev) base-commit: f2dd8896846757829fb3033f41b89be3fc037d78 -- 2.30.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2021-11-30 20:31 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 20:30 Uwe Kleine-König [this message] 2021-12-07 9:08 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211130203026.360693-1-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH] mci: bcm2835: Don'\''t send MMC_CMD_GO_IDLE_STATE at the end of .init()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox