From: Michael Tretter <m.tretter@pengutronix.de>
To: barebox@lists.infradead.org
Cc: m.tretter@pengutronix.de
Subject: [PATCH v2 0/8] video: ssd1307fb: Add SPI support
Date: Thu, 23 Dec 2021 17:03:56 +0100 [thread overview]
Message-ID: <20211223160404.119970-1-m.tretter@pengutronix.de> (raw)
Hello,
The Solomon single-chip CMOS OLED/PLED driver with controller can be connected
to I2C or SPI. The driver already supports I2C. This series adds support for
SPI connected displays to the driver.
The bindings for the SPI connected display are still not documented. The
driver uses the (undocumented) solomon,ssd1306 compatible of the staging
driver in Linux, but uses properties defined for the solomon,ssd1306fb-i2c
compatible of the I2C driver. I moved the warning about the compatible from
the commit message into the driver to have it in the same place as the use of
the compatible and to allow to eventually remove it.
The driver still allows to use SPI and I2C with its own hand-rolled
abstraction, because the controller does not actually expose registers, but
simply accepts commands or data. I followed Ahmad's suggestions how to remove
the ugly #ifdefs and the driver looks a lot nicer now.
Patches 1-3 adjust the SPI and I2C frameworks to make them nicer to use for
drivers that support devices that may be connected via SPI or I2C.
Patches 4-7 refactor the driver to have fewer locations that refer to I2C to
simplify disabling the I2C support.
Patch 8 actually adds the SPI support and makes I2C optional.
Michael
---
Changelog:
v2:
- add new Patches 1-3 for the SPI and I2C frameworks
- use new SPI and I2C helpers to get rid of use of config macros
- move warning about undocumented compatible into driver
Michael Tretter (8):
spi: stub device_spi_driver if SPI is disabled
spi: add to_spi_device helper
i2c: stub device_i2c_driver if I2C is disabled
video: ssd1307fb: pass par instead of i2c client to write
video: ssd1307fb: don't use i2c client for logging
video: ssd1307fb: move i2c setup to single place
video: ssd1307fb: use function pointer for write
video: ssd1307fb: add spi support
drivers/video/Kconfig | 2 +-
drivers/video/ssd1307fb.c | 170 +++++++++++++++++++++++++-------------
include/i2c/i2c.h | 5 ++
include/spi/spi.h | 10 +++
4 files changed, 130 insertions(+), 57 deletions(-)
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2021-12-23 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 16:03 Michael Tretter [this message]
2021-12-23 16:03 ` [PATCH v2 1/8] spi: stub device_spi_driver if SPI is disabled Michael Tretter
2021-12-23 16:03 ` [PATCH v2 2/8] spi: add to_spi_device helper Michael Tretter
2021-12-23 16:03 ` [PATCH v2 3/8] i2c: stub device_i2c_driver if I2C is disabled Michael Tretter
2021-12-23 16:04 ` [PATCH v2 4/8] video: ssd1307fb: pass par instead of i2c client to write Michael Tretter
2021-12-23 16:04 ` [PATCH v2 5/8] video: ssd1307fb: don't use i2c client for logging Michael Tretter
2021-12-23 16:04 ` [PATCH v2 6/8] video: ssd1307fb: move i2c setup to single place Michael Tretter
2021-12-23 16:04 ` [PATCH v2 7/8] video: ssd1307fb: use function pointer for write Michael Tretter
2021-12-23 16:04 ` [PATCH v2 8/8] video: ssd1307fb: add spi support Michael Tretter
2022-01-03 8:06 ` [PATCH v2 0/8] video: ssd1307fb: Add SPI support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223160404.119970-1-m.tretter@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox