From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] parseopt: drop unused, duplicate, parseopt_u16
Date: Mon, 3 Jan 2022 13:02:05 +0100
Message-ID: <20220103120205.1728778-1-a.fatoum@pengutronix.de> (raw)
We always have sizeof(unsigned short) == sizeof(uint16_t), so
parseopt_u16() is exactly equivalent to parseopt_hu().
The former is unused anyway, so just drop it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/parseopt.h | 1 -
lib/parseopt.c | 31 -------------------------------
2 files changed, 32 deletions(-)
diff --git a/include/parseopt.h b/include/parseopt.h
index 5a40bdc219fe..a944c3655f77 100644
--- a/include/parseopt.h
+++ b/include/parseopt.h
@@ -6,7 +6,6 @@ void parseopt_llu_suffix(const char *options, const char *opt,
void parseopt_b(const char *options, const char *opt, bool *val);
void parseopt_hu(const char *options, const char *opt, unsigned short *val);
-void parseopt_u16(const char *options, const char *opt, uint16_t *val);
void parseopt_str(const char *options, const char *opt, char **val);
#endif /* __PARSEOPT_H__ */
diff --git a/lib/parseopt.c b/lib/parseopt.c
index 70983066d952..d0a27d8bf372 100644
--- a/lib/parseopt.c
+++ b/lib/parseopt.c
@@ -59,37 +59,6 @@ again:
*val = v;
}
-void parseopt_u16(const char *options, const char *opt, uint16_t *val)
-{
- const char *start;
- size_t optlen = strlen(opt);
- ulong v;
- char *endp;
-
-again:
- start = strstr(options, opt);
-
- if (!start)
- return;
-
- if (start > options && start[-1] != ',') {
- options = start;
- goto again;
- }
-
- if (start[optlen] != '=') {
- options = start;
- goto again;
- }
-
- v = simple_strtoul(start + optlen + 1, &endp, 0);
- if (v > U16_MAX)
- return;
-
- if (*endp == ',' || *endp == '\0')
- *val = v;
-}
-
void parseopt_str(const char *options, const char *opt, char **val)
{
const char *start;
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2022-01-03 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 12:02 Ahmad Fatoum [this message]
2022-01-05 8:01 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103120205.1728778-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
mail archive of the barebox mailing list
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
barebox@lists.infradead.org barebox@lists.infradead.org
public-inbox-index barebox
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git