From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] commands: time: add -n option for nanoseconds output
Date: Mon, 3 Jan 2022 13:03:10 +0100 [thread overview]
Message-ID: <20220103120310.1729050-1-a.fatoum@pengutronix.de> (raw)
The current millisecond output may be too coarse for debugging timing
of barebox functionality. Add an optional nanosecond output.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
commands/time.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/commands/time.c b/commands/time.c
index 25ba2da15ed5..2d9fb75e7a8c 100644
--- a/commands/time.c
+++ b/commands/time.c
@@ -9,7 +9,7 @@ static int do_time(int argc, char *argv[])
int i;
unsigned char *buf;
u64 start, end, diff64;
- unsigned long diff;
+ bool nanoseconds = false;
int len = 1; /* '\0' */
if (argc < 2)
@@ -20,7 +20,13 @@ static int do_time(int argc, char *argv[])
buf = xzalloc(len);
- for (i = 1; i < argc; i++) {
+ i = 1;
+ if (!strcmp(argv[i], "-n")) {
+ nanoseconds = true;
+ i++;
+ }
+
+ for (; i < argc; i++) {
strcat(buf, argv[i]);
strcat(buf, " ");
}
@@ -33,11 +39,10 @@ static int do_time(int argc, char *argv[])
diff64 = end - start;
- do_div(diff64, 1000000);
-
- diff = diff64;
+ if (!nanoseconds)
+ do_div(diff64, 1000000);
- printf("time: %lums\n", diff);
+ printf("time: %llu%cs\n", diff64, nanoseconds ? 'n' : 'm');
free(buf);
@@ -47,12 +52,14 @@ static int do_time(int argc, char *argv[])
BAREBOX_CMD_HELP_START(time)
BAREBOX_CMD_HELP_TEXT("Note: This command depends on COMMAND being interruptible,")
BAREBOX_CMD_HELP_TEXT("otherwise the timer may overrun resulting in incorrect results")
+BAREBOX_CMD_HELP_TEXT("Options:")
+BAREBOX_CMD_HELP_OPT ("-n", "output elapsed time in nanoseconds")
BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(time)
.cmd = do_time,
BAREBOX_CMD_DESC("measure execution duration of a command")
- BAREBOX_CMD_OPTS("COMMAND")
+ BAREBOX_CMD_OPTS("[-n] COMMAND")
BAREBOX_CMD_GROUP(CMD_GRP_MISC)
BAREBOX_CMD_HELP(cmd_time_help)
BAREBOX_CMD_END
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2022-01-03 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 12:03 Ahmad Fatoum [this message]
2022-01-05 8:50 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103120310.1729050-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox