mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <>
Cc: Ahmad Fatoum <>
Subject: [PATCH master] x86: <asm/io.h>: fix outl/outsl access size
Date: Fri,  7 Jan 2022 07:36:44 +0100	[thread overview]
Message-ID: <> (raw)

outl so far behaved like outb, probably due to a copy-paste error when
it was first added. We have three users in-tree for outl:

* drivers/serial/serial_ns16550_pci.c
  only for handling a Quatech qurik, which probably no one ever needed

* drivers/serial/serial_ns16550.c
  For platform drivers with a 4 byte I/O port resource. Only possible
  user is x86 and that has a 1 byte I/O port resource. Thus no one
  used this either.

* drivers/watchdog/itco_wdt.c
  Here it indeed triggers a bug, although in my testing the WDAT
  was functional without.

Fix this up so new code doesn't have to track this down.

Signed-off-by: Ahmad Fatoum <>
Cc: Steffen Trumtrar <>
 arch/x86/include/asm/io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
index 0971727bc63d..23854128cb06 100644
--- a/arch/x86/include/asm/io.h
+++ b/arch/x86/include/asm/io.h
@@ -63,13 +63,13 @@ BUILDIO(l, , int)
 #define outb	outb
 #define outw	outw
-#define outl	outb
+#define outl	outl
 #define inb	inb
 #define inw	inw
 #define inl	inl
 #define outsb	outsb
 #define outsw	outsw
-#define outsl	outsb
+#define outsl	outsl
 #define insb	insb
 #define insw	insw
 #define insl	insl

barebox mailing list

             reply	other threads:[~2022-01-07  6:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  6:36 Ahmad Fatoum [this message]
2022-01-10  8:18 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox