From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] compressed dtb: Make sure they are only available when supported
Date: Mon, 14 Feb 2022 11:12:00 +0100 [thread overview]
Message-ID: <20220214101200.1592706-1-s.hauer@pengutronix.de> (raw)
A board has to select CONFIG_USE_COMPRESSED_DTB either directly or
through arch specific options when it uses compressed dtbs. This is
easily forgotten. barebox compiles fine, but during runtime the
decompression code is missing and barebox won't start. As this happens
in the PBL possibly without output this may be unnecessarily hard to
debug.
Make sure compilation fails when a board uses compressed dtbs but
didn't select CONFIG_USE_COMPRESSED_DTB.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
scripts/gen-dtb-s | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/gen-dtb-s b/scripts/gen-dtb-s
index 4f8c62a0b8..1027db2804 100755
--- a/scripts/gen-dtb-s
+++ b/scripts/gen-dtb-s
@@ -58,6 +58,7 @@ fi
compressed=$(${CONFIG_SHELL} "${srctree}/scripts/file-size.sh" $dtb.lzo)
uncompressed=$(${CONFIG_SHELL} "${srctree}/scripts/file-size.sh" $dtb)
+echo "#ifdef CONFIG_USE_COMPRESSED_DTB"
echo ".section .dtbz.rodata.${name},\"a\""
echo ".balign STRUCT_ALIGNMENT"
echo ".global __dtb_z_${name}_start"
@@ -69,3 +70,4 @@ echo ".incbin \"$dtb.lzo\""
echo "__dtb_z_${name}_end:"
echo ".global __dtb_z_${name}_end"
echo ".balign STRUCT_ALIGNMENT"
+echo "#endif"
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2022-02-14 11:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214101200.1592706-1-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox