mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <>
To: Andrej Picej <>
Cc: Barebox List <>
Subject: Re: [PATCH 3/3] Revert "scripts/common: fix write_file when opened with mmap"
Date: Mon, 28 Feb 2022 11:16:34 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Feb 24, 2022 at 02:22:12PM +0100, Andrej Picej wrote:
> Hi Sascha,
> sorry for responding this late, but we are still getting the same errors as
> before when using bareboximd with these three patches.
> Are you sure we can revert this patch? The file can still be opened in
> bareboximd with mmap(), and then be written with this write_file(), which
> fails with the same error:
> > Cannot write to barebox.bin: Bad address
> > CRC: write crc token to barebox.bin failed: -14
> > Bad address

Damn, my bad. It seems my brain was on vacation. I just created a fix
for this, you should be on Cc.


Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       |  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

barebox mailing list

  reply	other threads:[~2022-02-28 10:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  9:42 [PATCH 1/3] scripts/common: Do not mmap in read_file_2() Sascha Hauer
2022-02-11  9:42 ` [PATCH 2/3] scripts: bareboximd: Use mmap when possible Sascha Hauer
2022-02-11  9:42 ` [PATCH 3/3] Revert "scripts/common: fix write_file when opened with mmap" Sascha Hauer
2022-02-24 13:22   ` Andrej Picej
2022-02-28 10:16     ` Sascha Hauer [this message]
2022-02-28 11:40       ` Andrej Picej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox