From: Sascha Hauer <s.hauer@pengutronix.de>
To: Denis Orlov <denorl2009@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: host: ehci: add GENERIC_PHY dependency to Kconfig
Date: Thu, 3 Mar 2022 10:55:14 +0100 [thread overview]
Message-ID: <20220303095514.GY19585@pengutronix.de> (raw)
In-Reply-To: <20220301091423.19871-1-denorl2009@gmail.com>
Hi Denis,
On Tue, Mar 01, 2022 at 12:14:22PM +0300, Denis Orlov wrote:
> With GENERIC_PHY disabled, EHCI driver initialization fails in
> ehci_probe() as calling phy_optional_get() returns "Function not
> implemented" value. So it seems reasonable to make USB_EHCI explicitly
> depend on GENERIC_PHY.
>
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
> drivers/usb/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index d38b4dcac4..cc71b76902 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -2,6 +2,7 @@
> config USB_EHCI
> bool "EHCI driver"
> depends on HAS_DMA
> + depends on GENERIC_PHY
This effectively disables the EHCI in a bunch of defconfigs. I finally
decided for the other approach and made phy_optional_get() return NULL
when GENERIC_PHY is disabled. This should solve this problem.
Applied the other patch in the series.
Sascha
>
> config USB_EHCI_OMAP
> depends on ARCH_OMAP3
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-03-03 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:14 Denis Orlov
2022-03-01 9:14 ` [PATCH 2/2] usb: host: ehci: reorder code in ehci_probe() Denis Orlov
2022-03-03 9:55 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303095514.GY19585@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=denorl2009@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox