From: Sascha Hauer <s.hauer@pengutronix.de>
To: Denis Orlov <denorl2009@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] MIPS: fix optimised memset returning garbage
Date: Mon, 14 Mar 2022 10:03:01 +0100 [thread overview]
Message-ID: <20220314090301.GN405@pengutronix.de> (raw)
In-Reply-To: <20220310204206.31942-1-denorl2009@gmail.com>
On Thu, Mar 10, 2022 at 11:42:06PM +0300, Denis Orlov wrote:
> There is a subtle bug in arch/mips/lib/memset.S, used if option
> MIPS_OPTIMIZED_STRING_FUNCTIONS is enabled, which results in not writing
> the correct return value into v0 register if the value to fill memory
> with is 0.
>
> The bug stems from a missing '.set noreorder' directive before the first
> beqz instruction. This results in an assembler stuffing a 'nop'
> instruction in the beqz delay slot instead of an instruction writing the
> return value into v0 register that was supposed to go there. That leads
> to an error that appears when reading memory from SPI Flash and that was
> mentioned here:
> http://lists.infradead.org/pipermail/barebox/2021-June/036557.html
>
> There are a few ways of fixing this bug. The directive '.set noreorder'
> that shows up a bit later in code could be moved up and placed right
> before the memset label (as it was originally in Linux codebase - see
> a583158c9ce822c96a718fbf877cec1e5f9ad75d). Or, rather, the move and the
> branch instruction could be swapped, thus allowing the assembler to
> properly place move in delay slot (as it is done in Linux now - see
> 68dec269ee29c3abfd09596fbee7e40d875a6ab3) - that is what is done in this
> patch.
>
> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
> ---
> arch/mips/lib/memset.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-03-14 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 13:40 [PATCH 0/1] " Denis Orlov
2022-03-10 13:40 ` [PATCH 1/1] " Denis Orlov
2022-03-10 14:32 ` [PATCH 0/1] " Antony Pavlov
2022-03-10 20:42 ` [PATCH v2] " Denis Orlov
2022-03-14 9:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314090301.GN405@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=denorl2009@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox