mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Andrej Picej <andrej.picej@norik.com>
Cc: barebox@lists.infradead.org, upstream@lists.phytec.de
Subject: Re: [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem
Date: Tue, 29 Mar 2022 10:56:06 +0200	[thread overview]
Message-ID: <20220329085606.GV12181@pengutronix.de> (raw)
In-Reply-To: <20220329073333.435822-1-andrej.picej@norik.com>

Hi Andrej,

On Tue, Mar 29, 2022 at 09:33:32AM +0200, Andrej Picej wrote:
> Function first goes through all the aliases which have the given stem.
> It then ensures that all the devices hiding under these aliases are
> probed.
> 
> User can specify one device_node which won't get probed. This is mainly
> for avoiding recursion if the function will be called from device probe
> function, or to specify the device which should get probed last. In the
> later case the user should probe the last device manually.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> Changes in v2:
>  - add check for deep probe support,
>  - users can now specify one device node, which won't get probed. This
>    ensures that one device can be probed last and we avoid recursion, if
> this device happens to have alias,
>  - fix function name (ensured -> ensure).

Your v2 came before I had a chance to react to your comments on v1, I
was on vacation last week. I looked at the issue from another
perspective and rather than ensuring a certain probe order I think we
should decouple the GPIO numbers (at least the ones from the SoC
internal controllers) from the probe order, see the patch I just sent.

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  parent reply	other threads:[~2022-03-29  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  7:33 Andrej Picej
2022-03-29  7:33 ` [PATCH v2 2/2] ARM: boards: phytec-som-imx6: probe all gpio devices before PMIC Andrej Picej
2022-03-29  8:56 ` Sascha Hauer [this message]
2022-03-29 10:43   ` [PATCH v2 1/2] of: implement new of_device_ensure_probed_by_alias_stem Andrej Picej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329085606.GV12181@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=andrej.picej@norik.com \
    --cc=barebox@lists.infradead.org \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox