mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <>
Cc:, Ahmad Fatoum <>
Subject: [PATCH 3/4] ARM: rpi: remove outdated comment after stack setup rework
Date: Mon, 25 Apr 2022 08:28:48 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Stack is now set up with ENTRY_FUNCTION_WITH_STACK, so board code need
not concern itself with what is allowed in C code and what isn't before
stack is setup.

Signed-off-by: Ahmad Fatoum <>
 arch/arm/boards/raspberry-pi/lowlevel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boards/raspberry-pi/lowlevel.c b/arch/arm/boards/raspberry-pi/lowlevel.c
index e9314fb27b25..7b9809b86cb7 100644
--- a/arch/arm/boards/raspberry-pi/lowlevel.c
+++ b/arch/arm/boards/raspberry-pi/lowlevel.c
@@ -40,7 +40,6 @@ static void copy_vc_fdt(void *dest, void *src, unsigned long max_size)
 #define rpi_stack_top(memsize) \
 	arm_mem_stack_top(BCM2835_SDRAM_BASE, BCM2835_SDRAM_BASE + memsize - VIDEOCORE_FDT_SZ)
-/* Must be inline since stack isn't setup yet. */
 static inline void start_raspberry_pi(unsigned long memsize, void *fdt,
 								void *vc_fdt)

barebox mailing list

  parent reply	other threads:[~2022-04-25  6:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  6:28 [PATCH 0/4] ARM: rpi: enable single entry point for all Ahmad Fatoum
2022-04-25  6:28 ` [PATCH 1/4] ARM: cpu: board-dt-2nd: call arm_cpu_lowlevel_init Ahmad Fatoum
2022-04-25  6:28 ` [PATCH 2/4] ARM: rpi: don't warn about lack of videocore fdt Ahmad Fatoum
2022-04-25  6:28 ` Ahmad Fatoum [this message]
2022-04-25  6:28 ` [PATCH 4/4] ARM: configs: rpi: add and document single barebox-dt-2nd bootloader Ahmad Fatoum
2022-04-25 10:43 ` [PATCH 0/4] ARM: rpi: enable single entry point for all Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH 3/4] ARM: rpi: remove outdated comment after stack setup rework' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox