From: Jules Maselbas <jmaselbas@kalray.eu> To: Oleksij Rempel <o.rempel@pengutronix.de> Cc: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de> Subject: Re: [PATCH v3 1/5] common: add $global.serial_number with device tree fixup Date: Thu, 28 Apr 2022 14:59:18 +0200 [thread overview] Message-ID: <20220428125918.GE25550@tellis.lin.mbt.kalray.eu> (raw) In-Reply-To: <20220427121413.1887458-2-o.rempel@pengutronix.de> Hi, On Wed, Apr 27, 2022 at 02:14:09PM +0200, Oleksij Rempel wrote: > From: Ahmad Fatoum <a.fatoum@pengutronix.de> > > This new variable can be set by boards from C code or from the > environment to change the serial number fixed up into the kernel device > tree. Very nice! This will be usefull :) > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > common/Kconfig | 5 +++++ > common/misc.c | 16 ++++++++++++++++ > common/oftree.c | 9 +++++++++ > include/common.h | 3 +++ > 4 files changed, 33 insertions(+) > > diff --git a/common/Kconfig b/common/Kconfig > index f7a6a96e87..d08302a573 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -1066,6 +1066,11 @@ config MACHINE_ID > Note: if no hashable information is available no machine id will be passed > to the kernel. > > +config SERIAL_NUMBER_FIXUP > + bool "fix up board serial number" > + help > + fixup serial number supplied by board code info device tree > + > config SYSTEMD_OF_WATCHDOG > bool "inform devicetree-enabled kernel of used watchdog" > depends on WATCHDOG && OFTREE && FLEXIBLE_BOOTARGS > diff --git a/common/misc.c b/common/misc.c > index 226635f0d4..3b3bc05bfd 100644 > --- a/common/misc.c > +++ b/common/misc.c > @@ -149,6 +149,7 @@ EXPORT_SYMBOL(barebox_get_model); > BAREBOX_MAGICVAR(global.model, "Product name of this hardware"); > > static char *hostname; > +static char *serial_number; > > /* > * The hostname is supposed to be the shortname of a board. It should > @@ -179,6 +180,21 @@ EXPORT_SYMBOL(barebox_set_hostname_no_overwrite); > BAREBOX_MAGICVAR(global.hostname, > "shortname of the board. Also used as hostname for DHCP requests"); > > +void barebox_set_serial_number(const char *__serial_number) > +{ > + globalvar_add_simple_string("serial_number", &serial_number); > + > + free(serial_number); > + serial_number = xstrdup(__serial_number); > +} > + > +const char *barebox_get_serial_number(void) > +{ > + return serial_number; > +} > + > +BAREBOX_MAGICVAR(global.serial_number, "Board serial number"); > + > void __noreturn panic(const char *fmt, ...) > { > va_list args; > diff --git a/common/oftree.c b/common/oftree.c > index bce0ff09d6..c6d75055cc 100644 > --- a/common/oftree.c > +++ b/common/oftree.c > @@ -207,6 +207,15 @@ static int of_fixup_bootargs(struct device_node *root, void *unused) > int instance = reset_source_get_instance(); > struct device_d *dev; > > + if (IS_ENABLED(CONFIG_SERIAL_NUMBER_FIXUP)) { > + const char *serialno; > + > + serialno = getenv("global.serial_number"); > + if (serialno) > + of_property_write_string(root, "serial-number", serialno); > + > + } > + > node = of_create_node(root, "/chosen"); > if (!node) > return -ENOMEM; > diff --git a/include/common.h b/include/common.h > index 4167d4676e..967502a7ab 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -126,4 +126,7 @@ const char *barebox_get_hostname(void); > void barebox_set_hostname(const char *); > void barebox_set_hostname_no_overwrite(const char *); > > +const char *barebox_get_serial_number(void); > +void barebox_set_serial_number(const char *); > + > #endif /* __COMMON_H_ */ > -- > 2.30.2 > > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-04-28 13:01 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-27 12:14 [PATCH v3 0/5] add different OF board fixups Oleksij Rempel 2022-04-27 12:14 ` [PATCH v3 1/5] common: add $global.serial_number with device tree fixup Oleksij Rempel 2022-04-28 12:59 ` Jules Maselbas [this message] 2022-04-28 13:16 ` Ulrich Ölmann 2022-04-29 4:52 ` Oleksij Rempel 2022-04-29 7:35 ` Sascha Hauer 2022-04-27 12:14 ` [PATCH v3 2/5] ARM: boards: protonic-imx6: make use of barebox_set_serial_number() Oleksij Rempel 2022-04-27 12:14 ` [PATCH v3 3/5] of: add generic of_fixup_machine_compatible() Oleksij Rempel 2022-04-29 8:07 ` Sascha Hauer 2022-04-27 12:14 ` [PATCH v3 4/5] ARM: boards: skov-imx6: make use of of_fixup_machine_compatible() Oleksij Rempel 2022-04-27 12:14 ` [PATCH v3 5/5] ARM: boards: protonic-imx6: add HW revision specific machine compatible Oleksij Rempel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220428125918.GE25550@tellis.lin.mbt.kalray.eu \ --to=jmaselbas@kalray.eu \ --cc=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=o.rempel@pengutronix.de \ --subject='Re: [PATCH v3 1/5] common: add $global.serial_number with device tree fixup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox