From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org, ore@pengutronix.de
Subject: Re: [PATCH master] ARM: rpi: fix CM3 breakage after multi-image rework
Date: Tue, 3 May 2022 09:12:26 +0200 [thread overview]
Message-ID: <20220503071226.GB4012@pengutronix.de> (raw)
In-Reply-To: <20220502142959.1325298-1-a.fatoum@pengutronix.de>
On Mon, May 02, 2022 at 04:29:59PM +0200, Ahmad Fatoum wrote:
> barebox used to apply quirks by asking VideoCore firmware. If this was
> not possible, an error message is printed, but other initialization
> happened as expected. With the move to board driver matched by DT, we
> incur two breakages:
>
> - Compute Module 3/3+ used to be explicitly supported, but are absent
> in new compatible list
> - Unsupported variants used to initialize with only an error message,
> but now their revision ID must be known
>
> Fix this by amending the compatible list with all non-Raspberry Pi 4
> compatibles listed in the binding. We also make existence of a match
> data optional and error out if it doesn't exist. This is so far unused,
> but it conveys the intent for future users.
>
> Fixes: c062cd5cf47d ("ARM: rpi: validate devicetree compatible instead of changing model name")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Only build-tested.
> ---
> arch/arm/boards/raspberry-pi/rpi-common.c | 32 ++++++++++++++++++++---
> arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
> 2 files changed, 29 insertions(+), 4 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-05-03 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:29 Ahmad Fatoum
2022-05-03 7:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220503071226.GB4012@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ore@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox