From: Sascha Hauer <s.hauer@pengutronix.de> To: Denis Orlov <denorl2009@gmail.com> Cc: barebox@lists.infradead.org Subject: Re: [PATCH] ata: ahci: use correct macro when calculating offsets in dma memory Date: Wed, 11 May 2022 08:46:25 +0200 [thread overview] Message-ID: <20220511064625.GK4012@pengutronix.de> (raw) In-Reply-To: <20220505144440.29188-1-denorl2009@gmail.com> On Thu, May 05, 2022 at 05:44:40PM +0300, Denis Orlov wrote: > The macro that indicates the size of a single element in the command > list was incorrectly used instead of the macro that stands for the size > of the whole list. > > Signed-off-by: Denis Orlov <denorl2009@gmail.com> > --- > drivers/ata/ahci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index f707efb50f..eb9e1bd133 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -310,15 +310,15 @@ static int ahci_init_port(struct ahci_port *ahci_port) > /* > * Second item: Received-FIS area > */ > - ahci_port->rx_fis = mem + AHCI_CMD_SLOT_SZ; > - ahci_port->rx_fis_dma = mem_dma + AHCI_CMD_SLOT_SZ; > + ahci_port->rx_fis = mem + AHCI_CMD_LIST_SZ; > + ahci_port->rx_fis_dma = mem_dma + AHCI_CMD_LIST_SZ; > > /* > * Third item: data area for storing a single command > * and its scatter-gather table > */ > - ahci_port->cmd_tbl = mem + AHCI_CMD_SLOT_SZ + AHCI_RX_FIS_SZ; > - ahci_port->cmd_tbl_dma = mem_dma + AHCI_CMD_SLOT_SZ + AHCI_RX_FIS_SZ; > + ahci_port->cmd_tbl = mem + AHCI_CMD_LIST_SZ + AHCI_RX_FIS_SZ; > + ahci_port->cmd_tbl_dma = mem_dma + AHCI_CMD_LIST_SZ + AHCI_RX_FIS_SZ; > > ahci_port_debug(ahci_port, "cmd_tbl = 0x%p (0x%pa)\n", > ahci_port->cmd_tbl, ahci_port->cmd_tbl_dma); > -- > 2.20.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-05-11 6:47 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-05 14:44 Denis Orlov 2022-05-11 6:46 ` Sascha Hauer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220511064625.GK4012@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=denorl2009@gmail.com \ --subject='Re: [PATCH] ata: ahci: use correct macro when calculating offsets in dma memory' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox