From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: xload: Fix compile without CONFIG_MTD
Date: Fri, 3 Jun 2022 08:56:21 +0200 [thread overview]
Message-ID: <20220603065621.GP2387@pengutronix.de> (raw)
In-Reply-To: <20220601071452.17033-1-eagle.alexander923@gmail.com>
On Wed, Jun 01, 2022 at 10:14:52AM +0300, Alexander Shiyan wrote:
> arm-linux-ld: arch/arm/mach-omap/xload.o: in function read_mtd_barebox':
> /home/ARM/barebox/arch/arm/mach-omap/xload.c:75: undefined reference to mtd_peb_read_file'
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> arch/arm/mach-omap/xload.c | 72 ++++++++++++++++++--------------------
> 1 file changed, 34 insertions(+), 38 deletions(-)
>
> static __noreturn int omap_xload(void)
> {
> - void *func;
> + void *func = NULL;
>
> if (!barebox_part)
> barebox_part = &default_part;
> @@ -310,10 +308,8 @@ static __noreturn int omap_xload(void)
> } else if (IS_ENABLED(CONFIG_FS_OMAP4_USBBOOT)) {
> printf("booting from USB\n");
> func = omap4_xload_boot_usb();
> - } else {
> + } else
> printf("booting from USB not enabled\n");
> - func = NULL;
> - }
> break;
> case BOOTSOURCE_NAND:
> printf("booting from NAND\n");
> @@ -327,16 +323,16 @@ static __noreturn int omap_xload(void)
> if (IS_ENABLED(CONFIG_OMAP_SERIALBOOT)) {
> printf("booting from serial\n");
> func = omap_serial_boot();
> - break;
> }
> + break;
> case BOOTSOURCE_NET:
> if (IS_ENABLED(CONFIG_AM33XX_NET_BOOT)) {
> printf("booting from NET\n");
> func = am33xx_net_boot();
> - break;
> } else {
> printf("booting from network not enabled\n");
> }
> + break;
Despite being the first hunk a no-op, these ones look quite useful.
Should we make a separate patch from it?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2022-06-03 6:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 7:14 Alexander Shiyan
2022-06-02 6:55 ` Sascha Hauer
2022-06-02 8:07 ` Ahmad Fatoum
2022-06-02 8:59 ` Alexander Shiyan
2022-06-02 9:01 ` Ahmad Fatoum
2022-06-02 9:10 ` Alexander Shiyan
2022-06-03 6:56 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603065621.GP2387@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox