From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Sascha Hauer <sha@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition
Date: Fri, 10 Jun 2022 08:36:35 +0200 [thread overview]
Message-ID: <20220610063635.GF16749@pengutronix.de> (raw)
In-Reply-To: <0bc9c029-ee77-ae1c-f9a5-083c3db5544a@pengutronix.de>
On Thu, Jun 09, 2022 at 04:12:39PM +0200, Ahmad Fatoum wrote:
> On 09.06.22 16:10, Sascha Hauer wrote:
> > On Thu, Jun 09, 2022 at 03:09:36PM +0200, Ahmad Fatoum wrote:
> >> Fastboot would fall back to a raw copy even for bbu- partitions if
> >> no barebox_update handler was found. Prevent this by bailing out
> >> with an error code.
> >>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >> v2 -> v3:
> >> - bail out instead of only printing message and falling back
> >> to raw copy (Sascha)
> >> v1 -> v2:
> >> - print message in case barebox_update handler is not found
> >> ---
> >> common/fastboot.c | 9 +++++++--
> >> 1 file changed, 7 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/common/fastboot.c b/common/fastboot.c
> >> index 330a06f5a32f..a5cf04b39ecd 100644
> >> --- a/common/fastboot.c
> >> +++ b/common/fastboot.c
> >> @@ -683,8 +683,13 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
> >> };
> >>
> >> handler = bbu_find_handler_by_device(data.devicefile);
> >> - if (!handler)
> >> - goto copy;
> >> + if (!handler) {
> >> + fastboot_tx_print(fb, FASTBOOT_MSG_FAIL,
> >> + "No barebox update handler registered for %s",
> >> + data.devicefile);
> >> + ret = -ENOENT;
> >> + goto out;
> >> + }
> >
> > I didn't verify that, but I believe a full raw bootable disk image
> > generated for i.MX will be detected as barebox image. With this patch we
> > wouldn't be able to flash that anymore.
>
> Can we just apply v2 and see how often we see the message?
Or maybe the 'is a barebox image' detection is not strict enough? We know
the image size, right? Is there a way to determine the size of the actual
barebox image? If the two differ then it's not a barebox image after all.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-06-10 6:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 13:09 [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions Ahmad Fatoum
2022-06-09 13:09 ` [PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition Ahmad Fatoum
2022-06-09 13:11 ` [PATCH] fixup! " Ahmad Fatoum
2022-06-09 14:10 ` [PATCH v3 2/2] " Sascha Hauer
2022-06-09 14:12 ` Ahmad Fatoum
2022-06-10 6:36 ` Michael Olbrich [this message]
2022-06-10 6:57 ` Sascha Hauer
2022-06-10 8:35 ` [PATCH v3 1/2] fastboot: always try barebox_update handler for bbu- partitions Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610063635.GF16749@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox