mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <>
To: "Uwe Kleine-König" <>
Cc:, David Jander <>
Subject: Re: [PATCH] ARM: i.MX8MM: Consolidate common code to load image and jump to it via TF-A
Date: Wed, 6 Jul 2022 14:01:35 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Uwe,

thanks for the patch.

On 22-07-06, Uwe Kleine-König wrote:


> @@ -96,11 +92,6 @@ extern struct dram_timing_info imx8mm_evk_dram_timing;
>  static void start_atf(void)
>  {
> -	size_t bl31_size;
> -	const u8 *bl31;
> -	enum bootsource src;
> -	int instance;
> -
>  	/*
>  	 * If we are in EL3 we are running for the first time and need to
>  	 * initialize the DRAM and run TF-A (BL31). The TF-A will then jump
> @@ -112,35 +103,7 @@ static void start_atf(void)
>  	power_init_board();
>  	imx8mm_ddr_init(&imx8mm_evk_dram_timing);

I would move the imx8mm_ddr_init() into your helper
imx8mm_load_and_start_image_via_tfa() and pass the timing as argument.
So your helper doesn't depend on the 'hopefully' intialized DRAM. Else I
would add a comment above your helper, that the DRAM must be initialized
before calling this function.


  reply	other threads:[~2022-07-06 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  8:12 Uwe Kleine-König
2022-07-06 12:01 ` Marco Felsch [this message]
2022-07-06 14:48   ` Uwe Kleine-König
2022-07-11 10:51 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox