mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: add hint on how to resolve warning about vmmc-supply
Date: Tue, 9 Aug 2022 07:24:49 +0200	[thread overview]
Message-ID: <20220809052449.GB31528@pengutronix.de> (raw)
In-Reply-To: <20220724063920.1774718-1-a.fatoum@pengutronix.de>

On Sun, Jul 24, 2022 at 08:39:20AM +0200, Ahmad Fatoum wrote:
> For legacy reasons, we do not fail the MCI registration when a regulator
> can't be immediately requested, but we at least print a warning when
> this happens. Add a comment guiding the user into how to resolve the
> warning.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mci/mci-core.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index b8f71e15986e..8c08a4f61f63 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1941,6 +1941,16 @@ int mci_register(struct mci_host *host)
>  
>  	host->supply = regulator_get(hw_dev, "vmmc");
>  	if (IS_ERR(host->supply)) {
> +		/*
> +		 * If you know your regulator to be always online on boot, but
> +		 * can't easily add a barebox driver for it, you may use
> +		 * barebox,allow-dummy-supply in your board's regulator device
> +		 * tree node to side step this warning.
> +		 *
> +		 * If you run into this warning, because your regulator driver
> +		 * hasn't probed the device yet, consider enabling deep probe
> +		 * for your board, to probe dependencies on demand.
> +		 */
>  		dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n");
>  		host->supply = NULL;
>  	}
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2022-08-09  5:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24  6:39 Ahmad Fatoum
2022-08-09  5:24 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809052449.GB31528@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox