From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 2/4] net: designware: eqos: stm32: remove duplicate error message
Date: Tue, 9 Aug 2022 08:24:20 +0200 [thread overview]
Message-ID: <20220809062422.1749563-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20220809062422.1749563-1-a.fatoum@pengutronix.de>
clk_bulk_enable will already print an error message, so printing one
more is unnecessary.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/net/designware_stm32.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/designware_stm32.c b/drivers/net/designware_stm32.c
index 0a5ced98f522..43f2d0987c8f 100644
--- a/drivers/net/designware_stm32.c
+++ b/drivers/net/designware_stm32.c
@@ -163,14 +163,7 @@ static int eqos_init_stm32(struct device_d *dev, struct eqos *eqos)
dev_dbg(dev, "No phy clock provided. Continuing without.\n");
}
- ret = clk_bulk_enable(priv->num_clks, priv->clks);
- if (ret < 0) {
- eqos_err(eqos, "clk_bulk_enable() failed: %s\n",
- strerror(-ret));
- return ret;
- }
-
- return 0;
+ return clk_bulk_enable(priv->num_clks, priv->clks);
}
static struct eqos_ops stm32_ops = {
--
2.30.2
next prev parent reply other threads:[~2022-08-09 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 6:24 [PATCH 1/4] net: designware: rework Kconfig text and menu structure Ahmad Fatoum
2022-08-09 6:24 ` Ahmad Fatoum [this message]
2022-08-09 6:24 ` [PATCH 3/4] net: designware: eqos: replace double accounting of interface up status Ahmad Fatoum
2022-08-09 6:24 ` [PATCH 4/4] net: designware: eqos: remove undefined eqos_reset prototype Ahmad Fatoum
2022-08-09 9:32 ` [PATCH 1/4] net: designware: rework Kconfig text and menu structure Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809062422.1749563-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox