From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] of: implement of_append_property
Date: Tue, 9 Aug 2022 09:26:59 +0200 [thread overview]
Message-ID: <20220809072659.qq7pdgm3rqwhoiwv@pengutronix.de> (raw)
In-Reply-To: <20220809055733.1544311-1-a.fatoum@pengutronix.de>
Hi Ahmad,
On 22-08-09, Ahmad Fatoum wrote:
> board code fix up the device tree for OS consumption. Sometimes it's
> useful for the fixup to append onto an existing property.
> Add a helper that simplifies this.
do you have a particular use-case for this?
Regards,
Marco
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/of/base.c | 36 ++++++++++++++++++++++++++++++++++++
> include/of.h | 8 ++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index 101b2f74c74f..0893bdf3e04f 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -2321,6 +2321,42 @@ int of_set_property(struct device_node *np, const char *name, const void *val, i
> return 0;
> }
>
> +int of_append_property(struct device_node *np, const char *name, const void *val, int len)
> +{
> + struct property *pp;
> + void *buf = NULL;
> + int orig_len = 0;
> +
> + if (!np)
> + return -ENOENT;
> +
> + pp = of_find_property(np, name, NULL);
> + if (pp) {
> + buf = pp->value;
> + orig_len = pp->length;
> + }
> +
> + buf = realloc(buf, orig_len + len);
> + if (!buf)
> + return -ENOMEM;
> +
> + memcpy(buf + orig_len, val, len);
> +
> + if (pp) {
> + pp->value = buf;
> + pp->length += len;
> +
> + if (pp->value_const) {
> + memcpy(buf, pp->value_const, orig_len);
> + pp->value_const = NULL;
> + }
> + } else {
> + pp = __of_new_property(np, name, buf, len);
> + }
> +
> + return 0;
> +}
> +
> int of_property_sprintf(struct device_node *np,
> const char *propname, const char *fmt, ...)
> {
> diff --git a/include/of.h b/include/of.h
> index c65cef5a5a7c..97b4b3dd79bd 100644
> --- a/include/of.h
> +++ b/include/of.h
> @@ -131,6 +131,8 @@ extern struct device_node *of_get_cpu_node(int cpu, unsigned int *thread);
>
> extern int of_set_property(struct device_node *node, const char *p,
> const void *val, int len, int create);
> +extern int of_append_property(struct device_node *np, const char *p,
> + const void *val, int len);
> extern struct property *of_new_property(struct device_node *node,
> const char *name, const void *data, int len);
> extern struct property *of_new_property_const(struct device_node *node,
> @@ -515,6 +517,12 @@ static inline int of_set_property(struct device_node *node, const char *p,
> return -ENOSYS;
> }
>
> +static inline int of_append_property(struct device_node *np, const char *p,
> + const void *val, int len)
> +{
> + return -ENOSYS;
> +}
> +
> static inline struct property *of_new_property(struct device_node *node,
> const char *name, const void *data, int len)
> {
> --
> 2.30.2
>
>
>
next prev parent reply other threads:[~2022-08-09 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 5:57 Ahmad Fatoum
2022-08-09 5:57 ` [PATCH 2/2] test: self: add tests for of_append_property Ahmad Fatoum
2022-08-09 7:26 ` Marco Felsch [this message]
2022-08-09 8:29 ` [PATCH 1/2] of: implement of_append_property Ahmad Fatoum
2022-08-09 9:24 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809072659.qq7pdgm3rqwhoiwv@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox