From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/9] net: macb: Allocate own receive buffer
Date: Mon, 19 Sep 2022 10:01:26 +0200 [thread overview]
Message-ID: <20220919080133.877651-3-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20220919080133.877651-1-s.hauer@pengutronix.de>
Use a driver private buffer as network receive buffer rather than the
globally allocated ones which will be removed soon.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/net/macb.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 511846122a..5dbca1553e 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -64,6 +64,7 @@ struct macb_device {
void *rx_buffer;
void *tx_buffer;
+ void *rx_packet_buf;
struct macb_dma_desc *rx_ring;
struct macb_dma_desc *tx_ring;
struct macb_dma_desc *gem_q1_descs;
@@ -230,16 +231,15 @@ static int macb_recv(struct eth_device *edev)
taillen = length - headlen;
dma_sync_single_for_cpu((unsigned long)buffer,
headlen, DMA_FROM_DEVICE);
- memcpy((void *)NetRxPackets[0], buffer, headlen);
+ memcpy(macb->rx_packet_buf, buffer, headlen);
dma_sync_single_for_cpu((unsigned long)macb->rx_buffer,
taillen, DMA_FROM_DEVICE);
- memcpy((void *)NetRxPackets[0] + headlen,
- macb->rx_buffer, taillen);
+ memcpy(macb->rx_packet_buf + headlen, macb->rx_buffer, taillen);
dma_sync_single_for_device((unsigned long)buffer,
headlen, DMA_FROM_DEVICE);
dma_sync_single_for_device((unsigned long)macb->rx_buffer,
taillen, DMA_FROM_DEVICE);
- net_receive(edev, NetRxPackets[0], length);
+ net_receive(edev, macb->rx_packet_buf, length);
} else {
dma_sync_single_for_cpu((unsigned long)buffer, length,
DMA_FROM_DEVICE);
@@ -898,6 +898,8 @@ static int macb_probe(struct device_d *dev)
macb->gem_q1_descs = dma_alloc_coherent(GEM_Q1_DESC_BYTES,
DMA_ADDRESS_BROKEN);
+ macb->rx_packet_buf = xmalloc(PKTSIZE);
+
macb_reset_hw(macb);
ncfgr = macb_mdc_clk_div(macb);
ncfgr |= MACB_BIT(PAE); /* PAuse Enable */
@@ -921,6 +923,8 @@ static void macb_remove(struct device_d *dev)
struct macb_device *macb = dev->priv;
macb_halt(&macb->netdev);
+
+ free(macb->rx_packet_buf);
}
static const struct macb_config fu540_c000_config = {
--
2.30.2
next prev parent reply other threads:[~2022-09-19 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 8:01 [PATCH 0/9] Reduce usage of NetRxPackets[] Sascha Hauer
2022-09-19 8:01 ` [PATCH 1/9] net: tap: Allocate own receive buffer Sascha Hauer
2022-09-19 8:01 ` Sascha Hauer [this message]
2022-09-19 8:01 ` [PATCH 3/9] net: cs8900: " Sascha Hauer
2022-09-19 8:01 ` [PATCH 4/9] net: liteeth: Do not use NetRxPackets Sascha Hauer
2022-09-19 8:01 ` [PATCH 5/9] net: efi-snp: Allocate own receive buffer Sascha Hauer
2022-09-19 8:01 ` [PATCH 6/9] net: smc91111: " Sascha Hauer
2022-09-19 8:01 ` [PATCH 7/9] net: smc911x: " Sascha Hauer
2022-09-19 8:01 ` [PATCH 8/9] net: ks8851_mll: " Sascha Hauer
2022-09-19 8:01 ` [PATCH 9/9] net: remove altera_tse driver Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919080133.877651-3-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox