From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Trent Piepho <trent.piepho@igorinstitute.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: Makefile.lib: cmd_dtc: warning: missing whitespace after the macro name
Date: Thu, 22 Sep 2022 19:24:21 +0300 [thread overview]
Message-ID: <20220922192421.62a169b0993a454da401cc8f@gmail.com> (raw)
In-Reply-To: <20220919091410.GC6477@pengutronix.de>
On Mon, 19 Sep 2022 11:14:10 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
Hi Sascha!
> Hi Antony,
>
> On Mon, Sep 12, 2022 at 12:07:34PM +0300, Antony Pavlov wrote:
> > On Mon, 12 Sep 2022 10:01:52 +0200
> > Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> > > One side effect is that this gets even less readable.
> >
> > Yes, you are right :)
> >
> > > Another one would be that two dts filenames which only differ in the
> > > usage of '.' and '_' would result in the same define, but I think that
> > > case is negligible as this define is unused in barebox itself. It could
> > ^^^^^^^^^^^^^^^^^^^^^^^^
> > > be used by external dts fragments passed in via CONFIG_EXTERNAL_DTS_FRAGMENTS.
> > >
> > > Other than that, what side effects are you afraid of?
> >
> > I have an idea that someone relies on these *_dts macros.
> >
> > Now I see (as you have noted above) that there is no macro users in mainline source tree:
>
> Could you create a formal patch from this?
I'll a formal patch in a few days.
--
Best regards,
Antony Pavlov
prev parent reply other threads:[~2022-09-22 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 8:21 Antony Pavlov
2022-09-12 8:01 ` Sascha Hauer
2022-09-12 9:07 ` Antony Pavlov
2022-09-19 9:14 ` Sascha Hauer
2022-09-22 16:24 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922192421.62a169b0993a454da401cc8f@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=trent.piepho@igorinstitute.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox