mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] common: ubiformat: print 100 % complete message when done
Date: Wed,  5 Oct 2022 21:57:30 +0200	[thread overview]
Message-ID: <20221005195730.3405753-1-a.fatoum@pengutronix.de> (raw)

During formatting, current progress is printed every 300ms, e.g.:

  ubiformat: formatting eraseblock 1936 -- 95 % complete

When formatting is done, a single new line is printed. When ubiformat is
called in the fastboot workqueue, the barebox prompt won't be printed
again, so the user may think that update is stuck at the last message
printed. Improve user experience by explicitly printing a 100 % complete
message.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/ubiformat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/ubiformat.c b/common/ubiformat.c
index e10ce31ce659..1edfc5b2a3b9 100644
--- a/common/ubiformat.c
+++ b/common/ubiformat.c
@@ -444,7 +444,7 @@ static int format(struct ubiformat_args *args, struct mtd_info *mtd,
 	}
 
 	if (!args->quiet && !args->verbose)
-		printf("\n");
+		printf("\rubiformat: formatted all eraseblocks -- 100 %% complete\n");
 
 	if (!novtbl) {
 		if (eb1 == -1 || eb2 == -1) {
-- 
2.30.2




             reply	other threads:[~2022-10-05 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 19:57 Ahmad Fatoum [this message]
2022-10-07  8:30 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221005195730.3405753-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox