From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Michael Riesch <michael.riesch@wolfvision.net>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] regulator: rk808: fix misplaced DCDC_REG5
Date: Wed, 30 Nov 2022 15:24:10 +0100 [thread overview]
Message-ID: <20221130142410.2773477-1-a.fatoum@pengutronix.de> (raw)
Driver was written to mimic existing stpmic1 regulator driver, which had
the implicit assumption of a 1:1 relationship between of_match_data and
regulator configuration with same indices.
Yet DCDC_REG5 was not at the same place it was in the rk_regulator_cfg
due to likely a copy-paste mistake, leading to possibly the wrong
regulators being controlled. Fix this.
Reported-by: Michael Riesch <michael.riesch@wolfvision.net>
Suggested-by: Michael Riesch <michael.riesch@wolfvision.net>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/regulator/rk808-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index 39eadbd3ebe5..57b024cef33c 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -829,6 +829,7 @@ static struct of_regulator_match rk809_reg_matches[] = {
MATCH(809, DCDC_REG2, DCDC2),
MATCH(809, DCDC_REG3, DCDC3),
MATCH(809, DCDC_REG4, DCDC4),
+ MATCH(809, DCDC_REG5, DCDC5),
MATCH(809, LDO_REG1, LDO1),
MATCH(809, LDO_REG2, LDO2),
MATCH(809, LDO_REG3, LDO3),
@@ -838,7 +839,6 @@ static struct of_regulator_match rk809_reg_matches[] = {
MATCH(809, LDO_REG7, LDO7),
MATCH(809, LDO_REG8, LDO8),
MATCH(809, LDO_REG9, LDO9),
- MATCH(809, DCDC_REG5, DCDC5),
MATCH(809, SWITCH_REG1, SW1),
MATCH(809, SWITCH_REG2, SW2),
};
--
2.30.2
reply other threads:[~2022-11-30 14:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130142410.2773477-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox