mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ddr: imx8m: warn about unsupported frequencies
Date: Wed, 7 Dec 2022 07:56:03 +0100	[thread overview]
Message-ID: <20221207065603.GX29728@pengutronix.de> (raw)
In-Reply-To: <20221205132835.3002605-1-a.fatoum@pengutronix.de>

On Mon, Dec 05, 2022 at 02:28:34PM +0100, Ahmad Fatoum wrote:
> When adding a new board with a yet unsupported DDR frequency, PLL
> configuration is silently skipped, leading to a later hang during DDRC
> configuration. Improve the bring up user experience by printing a
> warning in that case. The user is then expected to extend
> imx8mm_fracpll_table, so PBL knows how PLLs should be configured for
> this new frequency.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/ddr/imx8m/ddrphy_utils.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/ddr/imx8m/ddrphy_utils.c b/drivers/ddr/imx8m/ddrphy_utils.c
> index c5d94e305086..3e03d4b75c9e 100644
> --- a/drivers/ddr/imx8m/ddrphy_utils.c
> +++ b/drivers/ddr/imx8m/ddrphy_utils.c
> @@ -344,6 +344,7 @@ void ddrphy_init_set_dfi_clk(unsigned int drate_mhz, enum ddrc_type type)
>  	case 400: drate = DDR_400; break;
>  	case 100: drate = DDR_100; break;
>  	default:
> +		pr_warn("Unsupported frequency %u\n", drate_mhz);
>  		return;
>  	}
>  
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      parent reply	other threads:[~2022-12-07  6:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 13:28 Ahmad Fatoum
2022-12-05 13:28 ` [PATCH 2/2] ddr: imx8m: use pr_warn instead of plain prints Ahmad Fatoum
2022-12-07  6:56 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207065603.GX29728@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox