From: Sascha Hauer <sha@pengutronix.de>
To: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>,
Alexander Shiyan <eagle.alexander923@gmail.com>
Subject: Re: [PATCH v2] of: partition: moan if adding a partition failed
Date: Mon, 9 Jan 2023 10:08:22 +0100 [thread overview]
Message-ID: <20230109090822.GB28911@pengutronix.de> (raw)
In-Reply-To: <20230109061401.1817658-1-u.oelmann@pengutronix.de>
On Mon, Jan 09, 2023 at 07:14:01AM +0100, Ulrich Ölmann wrote:
> Do not silently continue if e.g. the label of a partition defined in the
> devicetree collides with the name of a partition defined in a GPT on the device.
>
> While already at it, fix a double semicolon a few lines downward.
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
> drivers/of/partition.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/of/partition.c b/drivers/of/partition.c
> index abbda674d6cb..ed1114193062 100644
> --- a/drivers/of/partition.c
> +++ b/drivers/of/partition.c
> @@ -67,11 +67,13 @@ struct cdev *of_parse_partition(struct cdev *cdev, struct device_node *node)
> filename = basprintf("%s.%s", cdev->name, partname);
>
> new = devfs_add_partition(cdev->name, offset, size, flags, filename);
> - if (IS_ERR(new))
> + if (IS_ERR(new)) {
> + pr_err("Adding partition %s failed: %pe\n", filename, new);
> new = NULL;
> + }
>
> if (new)
> - new->device_node = node;;
> + new->device_node = node;
>
> if (IS_ENABLED(CONFIG_NVMEM) && of_device_is_compatible(node, "nvmem-cells")) {
> struct nvmem_device *nvmem = nvmem_partition_register(new);
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-01-09 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 6:14 Ulrich Ölmann
2023-01-09 9:08 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109090822.GB28911@pengutronix.de \
--to=sha@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
--cc=u.oelmann@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox